Skip to content

implement mechanism to reset PMIC #8

Description

@xypron

In the device-tree we have a node with compatible gpio-restart.

                gpiorst:gpio-restart {
                        compatible = "gpio-restart";
                        gpios = <&gpio 63 GPIO_ACTIVE_HIGH>;
                };

Why is CONFIG_SYSRESET_GPIO not selected to make use of it?

Activity

  1. jonathangray commented on May 10, 2021

    @jonathangray
    Contributor

    See starfive-tech/Fedora_on_StarFive#25
    Despite the device tree and code in the U-Boot and OpenSBI branches it appears that reset only works when talking to the PMIC over I2C or pushing the button next to the USB-C power which is connected to the PMIC.

  2. pdp7 commented on May 13, 2021

    @pdp7
    Collaborator
  3. xypron commented on May 20, 2021

    @xypron
    CollaboratorAuthor

    This issue was about U-Boot. It is good that we found out how to make a reset work in Linux.
    But we also want the reset command in U-Boot to work. So we shoudn't close this issue.

    The best solution would be to implement the reset in OpenSBI.

  4. reopened this on May 20, 2021
  5. pdp7 commented on May 20, 2021

    @pdp7
    Collaborator

    @xypron thank you for pointing that out and re-opening

  6. MichaelZhuxx commented on May 20, 2021

    @MichaelZhuxx
    Collaborator

    @pdp7 yes, that's my concern in todays weekly meeting, we need merge its same way(tell the pmic to reset the whole system) from linux to u-boot. @tekkamanninja please try to fix it. then I can offically release a u-boot binary. thanks.

  7. xypron commented on May 20, 2021

    @xypron
    CollaboratorAuthor

    @MichaelZhuxx
    The system reset should only be implemented once and that is in OpenSBI. U-Boot and Linux should call the system reset extension. This just like ARM does with PSCI.

  8. MichaelZhuxx commented on May 20, 2021

    @MichaelZhuxx
    Collaborator

    @xypron good point. I think that's the best way. @tekkamanninja what's your opinion?

  9. MichaelZhuxx commented on May 20, 2021

    @MichaelZhuxx
    Collaborator

    starfive-tech/opensbi@b5facf9
    yes, we have done same method in openSBI to enable the system reset by GPIO63. now we should implement it by I2C.

  10. changed the title [-]Missing sysreset[/-] [+]implement mechanism to reset SoC from u-boot or OpenSBI[/+] on May 27, 2021
  11. pdp7 commented on May 27, 2021

    @pdp7
    Collaborator

    starfive-tech/opensbi@b5facf9
    yes, we have done same method in openSBI to enable the system reset by GPIO63. now we should implement it by I2C.

    Yes, the does seem ideal to implement restarting PMIC via I2C in OpenSBI so that SBI reset will work.

  12. changed the title [-]implement mechanism to reset SoC from u-boot or OpenSBI[/-] [+]implement mechanism to reset PMIC[/+] on May 27, 2021
  13. pdp7 commented on Jul 1, 2021

    @pdp7
    Collaborator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions