Reason for use of defaultOp in UserOperationBuilder #118

Copy link

Copy link

Open

Open

Reason for use of defaultOp in UserOperationBuilder#118

Copy link

Description

sushisilence

opened on Dec 7, 2023

Issue body actions

Hello team,

What is the purpose of defaultOp in the UserOperationBuilder?

userop.js/src/builder.ts

Lines 28 to 38 in 1d9d0e0

	export class UserOperationBuilder {
	private defaultOp: IUserOperation;
	private currOp: IUserOperation;
	private middlewareStack: Array<UserOperationMiddlewareFn>;
	constructor() {
	this.defaultOp = { ...DEFAULT_USER_OP };
	this.currOp = { ...this.defaultOp };
	this.middlewareStack = [];
	}

I'm asking because in SimpleAccount.init():

userop.js/src/preset/builder/simpleAccount.ts

Lines 89 to 98 in 1d9d0e0

	const base = instance
	.useDefaults({
	sender: instance.proxy.address,
	signature: await instance.signer.signMessage(
	ethers.utils.arrayify(ethers.utils.keccak256("0xdead"))
	),
	})
	.useMiddleware(instance.resolveAccount)
	.useMiddleware(getGasPrice(instance.provider));

A default message is being signed, and some defaults are being set. For a normal EOA an extra signature is okay, but if an MPC/Hardware wallet is used, then an extra signature is not ideal.

Is it possible to skip signing a message in the SimpleAccount.init() method?
Thanks!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

Labels

No labels

No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

• Open in GitHub Copilot app