Conversation
Follow-up to stacklok#6388, which fixed the five plain renames from stacklok#6387. These are the rest, re-measured against e532cf0 rather than re-quoted from the issue: one had moved again since it was filed, and pkg/skills/feature_gate.go is already gone from the docs, so it is nine rather than ten. Four moved to toolhive-core, and the replacement is the import path the Go code uses today: pkg/permissions/profile.go -> toolhive-core/permissions pkg/registry/types.go -> toolhive-core/registry/types pkg/container/verifier/ -> toolhive-core/container/verifier pkg/errors/errors.go -> toolhive-core/httperr pkg/runner/retriever/retriever.go imports the verifier one, and docs/error-handling.md already used httperr.Code in the example directly above the list that still named pkg/errors. pkg/registry/schema_validation.go is named as the validator for schemas the same document already says are published in toolhive-core, so it points there too. pkg/vmcp/discovery/ is not in the tree. Discovery is, in pkg/vmcp/aggregator/discoverer.go, so the three references name the aggregator rather than dropping the idea. The vmcp-library row is removed because it lists a package that no longer exists and already said to use it via the aggregator. Every destination checked at e532cf0: the four toolhive-core links resolve, and the five in-tree paths are present. Signed-off-by: Melbin J Paulose <melbinjpaulose@gmail.com>
melbinjp
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
jhrozek,
rdimitrov and
tgrunnagle
as code owners
September 13, 2026 04:28
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6650 +/- ##
==========================================
- Coverage 78.98% 78.91% -0.07%
==========================================
Files 782 782
Lines 78065 78065
==========================================
- Hits 61658 61607 -51
- Misses 16402 16453 +51
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the rest of #6387, which is assigned to me. #6388 took the five plain renames; these are the nine that needed a decision about what the replacement should say.
Re-measured against
e532cf0rather than re-quoted from the issue. Two things changed since I filed it: one line had moved again, andpkg/skills/feature_gate.gois already gone from the docs, so it is nine rather than the ten I last counted.Four moved to toolhive-core
The replacement is the import path the Go code uses today, not a guess.
docs/arch/03-transport-architecture.mdpkg/permissions/profile.gotoolhive-core/permissionsdocs/arch/06-registry-system.mdpkg/registry/types.gotoolhive-core/registry/typesdocs/arch/06-registry-system.mdpkg/container/verifier/toolhive-core/container/verifierdocs/error-handling.mdpkg/errors/errors.gotoolhive-core/httperrTwo of these are self-evidencing.
pkg/runner/retriever/retriever.goimportstoolhive-core/container/verifier, anddocs/error-handling.mdalready useshttperr.Code(err)in the example directly above the list that still namedpkg/errors.pkg/registry/schema_validation.gois named as the validator for schemas the same document already says are published in toolhive-core, so it points there too.Discovery
pkg/vmcp/discovery/is not in the tree. Discovery is, inpkg/vmcp/aggregator/discoverer.go, so the three references name the aggregator rather than dropping the idea. Thevmcp-library.mdrow is removed: it lists a package that no longer exists, and it already told readers to use it via the aggregator.One left alone deliberately
docs/arch/10-virtual-mcp-architecture.mdstill has a Backend Enrichment Middleware section namingpkg/vmcp/server/backend_enrichment.go. That file went in #5622 and nothing in the tree replaces it, so unlike the others this is not a path that moved, it is a section describing something that is gone. Deleting a section is an editorial call rather than a path fix, so I have left it for you. Happy to send it as a one-line follow-up if you would like it removed.Verification
All four toolhive-core links resolve, and all five in-tree paths are present at
e532cf0. Docs only, no code changes.