Repository navigation
fix(studio): scan schedules in the breakpoint guard, and widen the schedule time field - #2365
Merged
Merged
Conversation
…hedule time field Two of the open items in #2303. - The breakpoint guard exempted all of `features/schedules/` as "pending" work that has since landed. The only `sm:` class there is the detail page's `sm:grid-cols-2`, which the prototype uses on the same grid, so it is listed with that reason and the exemption is removed. Schedules are now scanned like everything else. - The schedule form's time field was 120px wide. Below the md breakpoint the text is larger, and Chrome cut "11:59 PM" to "11:59 P". It is now 148px (136px was the narrowest width that showed the meridiem whole; 148px leaves clear room beside the clock icon). An e2e check pins the measured floor at a phone viewport. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
peppescg
approved these changes
Oct 16, 2026
peppescg
added a commit
that referenced
this pull request
Oct 16, 2026
…dth check main's phone time-width check (#2365) opens the dialog through a "Schedule task" button. This stack names that button "New scheduled task", so the check timed out on the merge with main. It now uses the new name, like the other schedule journeys. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The last open items in #2303.
Closes #2303.
What changed
breakpoints.test.tsexempted all offeatures/schedules/as "pending" work that has since landed (feat(studio): complete schedule management workspace #2194, Studio alignment: accessibility and 500px breakpoint sweep #2208). The onlysm:class there is the detail page'ssm:grid-cols-2, which the prototype uses on the same grid, so it is now listed with that reason and the exemption is gone. Schedules are scanned like every other feature, and the "reads every source" test now asserts that.w-[120px]. It is noww-[148px].Screenshots
Phone viewport (390px), same data, before and after:
"11:59 PM" is cut to "11:59 P".
The whole value fits, with room beside the clock icon.
The issue said the clipping reproduces at 1280px. In my capture it did not: at 1280px the text is 14px and "11:59 PM" fits at 120px. The field's text is larger below the
mdbreakpoint (18px at 390px), and that is where it is cut. 136px was the narrowest width that showed the whole value, and 148px leaves clear room.The third item, the docs about the authorization cue
Nothing to change here; it was already done and is closed by this PR's
Closes. The docs sentence was reworded in #2309 and no longer says the header shows the waiting state. The e2e case where the stream closes after the authorization event landed in #2319 (closeStreaminchat-header-stop.spec.ts).Verification
pnpm generated:checkpass.schedules.spec.tspasses (8 of 8).sm:grid-cols-2diff, and the new e2e check fails at the old 120px (Expected: >= 136, Received: 120).Not included
An automated check that the meridiem is not clipped.
scrollWidthcannot see the browser's built-in time control, so the e2e test pins the measured width floor (136px) at a phone viewport instead. That guards the width, not the rendering, and a different font or browser could need more.Fully or partially written by an AI agent.
🤖 Generated with Claude Code