Repository navigation
fix(studio): declare 400 and 429 on the skill files route, and stop hard-coding the route count - #2355
Merged
Conversation
…ard-coding the route count main's Studio job has been failing since the skill files route (#2155) landed next to the knowledge-route convention test (#2313). Each change was fine on its own: #2313 declared 400 and 429 on the 15 knowledge routes and pinned the count at 15, and #2155 added a 16th route without them. - Spread `transportErrors` into `listSkillFilesRoute` like the other knowledge routes. The OpenAPI document and generated types gain the two statuses. - The convention test no longer asserts an exact route count, so the next knowledge route is checked without editing the test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kantord
force-pushed
the
fix/studio-knowledge-route-statuses
branch
from
October 15, 2026 13:04
8dc3350 to
ff78e9f
Compare
peppescg
approved these changes
Oct 15, 2026
This was referenced Oct 15, 2026
This was referenced Oct 15, 2026
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main's "Mecatl Studio (apps/)" job has been failing since the skill files route (#2155) landed next to the knowledge-route convention test (#2313), and every PR that CI merges withmainfails the same test. Each change was fine on its own: #2313 declared400and429on the 15 knowledge routes and pinned the count at 15, and #2155 added a 16th route without them.The failure on
main:What changed
listSkillFilesRoutespreadstransportErrors, like the other knowledge routes.openapi.jsonandtypes.gen.tsare regenerated (pnpm run generate) and gain400and429forGET /api/v1/skills/{name}/files.400and429), so the next knowledge route is covered without editing the test.Behavior changes
None at runtime. The OpenAPI document and generated types gain two statuses on one route.
Verification
Rebased onto
mainat4aa238f3c(after #2316 to #2318 landed). On thatmain, the old test fails with the error above; with this change it passes. Biome, typecheck and the full Studio test suite (server 241, web 1,529) pass, andpnpm generated:checkshows no drift.Not included
A route-level registry for the knowledge routes. The test still finds them by path prefix, so a route under a new prefix would not be covered.
Fully or partially written by an AI agent.
🤖 Generated with Claude Code