Repository navigation
Conversation
kantord
added this pull request to stack #2325
October 14, 2026 13:27
41 tasks done
kantord
marked this pull request as ready for review
October 15, 2026 08:41
peppescg
approved these changes
Oct 15, 2026
peppescg
left a comment
peppescg
left a comment
Contributor
There was a problem hiding this comment.
Thanks Daniel. Clean extraction: the four sites now share one disabled rule and one key, and the tests pin the missing-target and remount behaviour. LGTM.
kantord
force-pushed
the
studio-followups/11-pending-ask-card
branch
6 times, most recently
from
October 15, 2026 13:00
2c822a1 to
4e6490c
Compare
kantord
force-pushed
the
studio-followups/11-pending-ask-card
branch
from
October 15, 2026 13:26
4e6490c to
4479d4a
Compare
The PresentPlan ? PlanReviewCard : ApprovalPanel ternary, with its key and the missing-controlTarget disabled rule, was copied in the transcript, Message, the side panel, and the tool-call list. One PendingAskCard now owns it; each surface still passes its own predicates and handlers. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kantord
force-pushed
the
studio-followups/11-pending-ask-card
branch
from
October 15, 2026 14:01
4479d4a to
c502327
Compare
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One component for the plan-or-ordinary ask card, which was copied at four sites.
Part of #2303 ("Tiny follow-up fixes"); it does not close it. This is PR 11 of 14 in a stack of draft PRs, reviewed and merged in order.
What changed
PendingAskCardandpendingAskKeyown thePresentPlan ? PlanReviewCard : ApprovalPanelternary, the key and the missing-controlTargetdisabled rule. The four sites (transcript,Message, side panel, tool-call list) use them; the issue said three. The key is exported because a React key on a component's inner element does not key it in a parent's.map.ToolCallControlsnow extendsPendingAskControls.Behavior changes
None.
Verification
Biome, typecheck, the full Studio test suite and
pnpm generated:checkpass on this branch, run on the assembled stack. The full Playwright suite passes on the stack tip (122 passed, 30 skipped, 0 failed, includingchat-approvalagainst a realmecatedbuild). Four new tests (plan vs ordinary, disabled without a control target, following the surface predicate, key remount on a new run); the missing-target and key tests fail without the fix.chat-approvale2e 4 of 4.Not included
The later refactors in this stack.
Fully or partially written by an AI agent.
🤖 Generated with Claude Code