Skip to content

test(app): eliminate real ToolHive probe deadline wait #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JAORMX merged 1 commit into from
Sep 25, 2026
Merged

test(app): eliminate real ToolHive probe deadline wait #1937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 31 additions & 29 deletions internal/app/registry_toolhive_anthropic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,37 +621,39 @@ func requireDeadlineNear(t *testing.T, observed <-chan deadlineObservation, want
}

func TestToolhiveProbeDeadlinePublishesHealthySibling(t *testing.T) {
observed := make(chan deadlineObservation, 2)
reg := &providerRegistry{
entries: map[string]providerEntry{
providerToolhive: {
id: providerToolhive, available: true,
lister: deadlineAwareLister{modelID: "openai-healthy", observed: observed},
},
providerToolhiveAnthropic: {
id: providerToolhiveAnthropic, available: true,
lister: deadlineAwareLister{stall: true, observed: observed},
synctest.Test(t, func(t *testing.T) {
observed := make(chan deadlineObservation, 2)
reg := &providerRegistry{
entries: map[string]providerEntry{
providerToolhive: {
id: providerToolhive, available: true,
lister: deadlineAwareLister{modelID: "openai-healthy", observed: observed},
},
providerToolhiveAnthropic: {
id: providerToolhiveAnthropic, available: true,
lister: deadlineAwareLister{stall: true, observed: observed},
},
},
},
meta: newLiveMetaStore(),
}
meta: newLiveMetaStore(),
}

bindDiscoveryFixture(t, reg)
started := time.Now()
if err := probeToolhive(reg, Config{}); err != nil {
t.Fatalf("probeToolhive: %v", err)
}
if elapsed := time.Since(started); elapsed < toolhiveProbeTimeout-300*time.Millisecond || elapsed > toolhiveProbeTimeout+time.Second {
t.Fatalf("probe elapsed = %v, want bounded near %v", elapsed, toolhiveProbeTimeout)
}
requireDeadlineNear(t, observed, toolhiveProbeTimeout)
requireDeadlineNear(t, observed, toolhiveProbeTimeout)
if model, ok := reg.meta.lookup(providerToolhive, "openai-healthy"); !ok || model.ID != "openai-healthy" {
t.Fatalf("healthy probe metadata was not published: %+v, ok=%v", model, ok)
}
if _, ok := reg.meta.lookup(providerToolhiveAnthropic, "openai-healthy"); ok {
t.Fatal("failed native probe published sibling metadata under the wrong provider")
}
bindDiscoveryFixture(t, reg)
started := time.Now()
if err := probeToolhive(reg, Config{}); err != nil {
t.Fatalf("probeToolhive: %v", err)
}
if elapsed := time.Since(started); elapsed != toolhiveProbeTimeout {
t.Fatalf("probe elapsed = %v, want %v", elapsed, toolhiveProbeTimeout)
}
requireDeadlineNear(t, observed, toolhiveProbeTimeout)
requireDeadlineNear(t, observed, toolhiveProbeTimeout)
if model, ok := reg.meta.lookup(providerToolhive, "openai-healthy"); !ok || model.ID != "openai-healthy" {
t.Fatalf("healthy probe metadata was not published: %+v, ok=%v", model, ok)
}
if _, ok := reg.meta.lookup(providerToolhiveAnthropic, "openai-healthy"); ok {
t.Fatal("failed native probe published sibling metadata under the wrong provider")
}
})
}

func TestToolhiveBackgroundRefreshCarriesOperationDeadline(t *testing.T) {
Expand Down
Loading