Repository navigation
feat(slack-bot): use sdk package - #1289
Conversation
6c51934 to
6fad474
Compare
samuv
left a comment
samuv
left a comment
There was a problem hiding this comment.
I found four issues to address, with the details inline. The two runtime regressions reproduce in focused tests; the existing 21 handler, configuration, and rate-limit tests and typecheck pass with the local SDK source.
I could not validate the published SDK package locally because GitHub Packages returned 403 with the available token. The PR's CI checks are green.
- Move session.run() inside the eviction try/catch — the server can reject a stuck-authorization session at run admission, before any event streams, which previously skipped eviction entirely. - Fix silent truncation when an established Slack stream breaks mid-run: track "failed" separately from "started" so the full answer still gets delivered via a final say(). - Subscribe to agent_session_stopped in the app manifest and README setup steps so the native stop button actually reaches the bot. - Make `task install` self-sufficient for GitHub Packages auth instead of documenting a NODE_AUTH_TOKEN-only command that doesn't actually configure pnpm. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
samuv
left a comment
samuv
left a comment
There was a problem hiding this comment.
Thanks for the fixes. All four previous findings are addressed in bc854b0, and I found no further issues in the follow-up.
Both original regression reproductions now pass, along with the 22 handler, configuration, and rate-limit tests, typecheck, and lint. Local tests used the SDK source; the Slack bot CI job against the published dependency is also green. I separately verified the install task's npmrc wiring and cleanup on success and failure with a stubbed install.
Summary
Development stage
declares
**Expected tasks:** 1, a non-placeholder**Combined rationale:**, and noruntime/public/operator/persistence/trust-boundary interface change (
None — rationale;workflow-only meta-changes may review process docs/skills here)
Contract linkage
Interface conformance
Issue relationship
Relates to #
Type of change
Test plan
Baseline checks
task lint)task test)go run ./cmd/mecademo)task docs)task site:build)task api:check)task api:update+engine/CHANGELOG.mdtask ac-trace-strict)/panel-reviewChanges
User-facing change
Special notes for reviewers