Repository navigation
Make the connectors page task-based - #1206
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
danbarr
left a comment
There was a problem hiding this comment.
Editorial review assessed against the final stack at #1208 (a9c7827). The task-based connector guide is a substantial improvement, particularly the distinction between registration methods, verification, and the two checks for in-cluster endpoints.
Please consolidate the access procedure with #1202. In docs/connector-gateway/connectors.mdx, Grant and revoke access repeats the group-grant steps, inheritance explanation, and Cedar-mode read-only behavior from connector-policies.mdx. This page also covers revocation, making it more operationally complete than the dedicated policy guide.
Make the policy guide the canonical home for the complete grant/revoke workflow. Keep a short access checkpoint and a descriptive link in connector management so readers can continue the registration workflow without maintaining two copies of the same instructions.
b5a89aa to
8e4e9bc
Compare
Visual regression failedCommit
Open the failed visual job · Download the full Playwright report If the change is intentional, a repository collaborator can comment |
8e4e9bc to
d195984
Compare
Fix console labels and reorganize the page around tasks: add (per method), verify and publish, authentication, grant and revoke access, activity, and edit or delete. Add when changes take effect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Update links for the moved credential and support pages. Addresses #1206 review: - body (5419970241): make connector-policies.mdx the canonical access guide Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d195984 to
751cbb3
Compare
danbarr
left a comment
There was a problem hiding this comment.
Approved from an editorial and information-architecture perspective. The findings from the stack review are addressed in the assembled result: administrator/owner audience, coherent navigation and credential-guide ownership, canonical access instructions, explicit API-only authentication, qualified usage reporting, and lowercase experience descriptions in prose. This approval does not assert live end-to-end validation of the deployment or examples.
Description
Rewrites
docs/connector-gateway/connectors.mdxas a task-based how-to, per #1184. Stacked on #1205; retarget tomainafter it merges.Label fixes
Several items in the issue's label table (Activate, Your workspace, Re-authenticate, the three-peer sources list) were already fixed by #1180, so they needed no change.
Structure
The page is now organized around tasks with numbered steps:
credentialRefreshInterval(15 minutes by default).The order differs slightly from the issue's list. Authentication comes before access, matching the prerequisite order on the authentication page and the fact that imported connectors arrive with no authentication.
Next steps now link to identity providers, managed secrets, and rolling out gateway clients. The description is rewritten. One inbound anchor in
connector-authentication.mdxis updated to the new heading.Verification
Console labels and behavior were checked in
stacklok-enterprise-platformate3da432, underenterprise/toolhive-cloud-ui/src/features/connectors-admin/:lib/columns.tsxadd-connector-dialog.tsxnoneauth, published on create, transport choice):import-connectors-dialog.tsxandactions.tsdiscover-connectors-dialog.tsxandconfiguration-tab.tsxaccess-tab.tsxandadd-group-dialog.tsxdelete-connector-dialog.tsxcomponents/metering/connector-activity-table.tsxandlib/metering/activity-period.tsThe timing values come from the comments on
refreshIntervalandcredentialRefreshIntervalinenterprise/connector-gateway/helm/values.yaml. The deny-on-unreachable behavior comes fromErrPolicyDecisionUnavailableininternal/infra/directory/adapter.go.npm run buildpasses, and Prettier and ESLint are clean.Needs SME eyes
Type of change
Related issues/PRs
Closes #1184. Part of #1175. Stacked on #1205.
Submitter checklist
Content and formatting
Navigation
sidebars.ts) updated for added, deleted, reordered, or renamed files (no changes needed)vercel.jsonfor moved, renamed, or deleted pages (no URLs changed)Reviewer checklist
Content
🤖 Generated with Claude Code