This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Repository navigation
Adds cli command to generate certificate - #291
Merged
Merged
Conversation
aponcedeleonch
force-pushed
the
generate-certs
branch
2 times, most recently
from
December 11, 2024 21:08
df22ab8 to
015f76c
Compare
This will add the code needed to generate certificates. It will also add a command to our cli for generating certificates. Our Dockerfile will also use the generate-certs command to be executed before the server is deployed. Meaning we will always have the certificates created in case they don't exist. Note that for having the certificates at host we would need to mount a volume to the container
aponcedeleonch
force-pushed
the
generate-certs
branch
from
December 11, 2024 22:33
015f76c to
0304252
Compare
yrobla
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add the code needed to generate certificates. It will also add a command to our cli for generating certificates.
Our Dockerfile will also use the generate-certs command to be executed before the server is deployed. Meaning we will always have the certificates created in case they don't exist.
Note that for having the certificates at host we would need to mount a volume to the container