This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Repository navigation
Use ollama python client for completion - #241
Merged
Merged
Conversation
aponcedeleonch
commented
Dec 10, 2024
aponcedeleonch
commented
Dec 10, 2024
ptelang
approved these changes
Dec 10, 2024
ptelang
left a comment
ptelang
left a comment
Contributor
There was a problem hiding this comment.
I tested this change and it works as expected. Great job!
Until now we had been using self-made calls to Ollama. The problem is that the output of the calls didn't follow the standard format of the other calls. Initally I tried to implement Ollama completion calls with LiteLLM but also their interfaces seem quite broken. I was getting errors using their method `acompletion` and everytime that I set `stream=False`. Hence I resorted to use python's official Ollama client and implemented normalizers for it
aponcedeleonch
force-pushed
the
ollama-litellm
branch
from
December 10, 2024 17:31
649c1b4 to
cd27b5c
Compare
aponcedeleonch
force-pushed
the
ollama-litellm
branch
from
December 10, 2024 17:39
cd27b5c to
a49514c
Compare
This was referenced Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now we had been using self-made calls to Ollama. The problem is that the output of the calls didn't follow the standard format of the other calls. Initally I tried to implement Ollama completion calls with LiteLLM but also their interfaces seem quite broken. I was getting errors using their method
acompletionand everytime that I setstream=False. Hence I resorted to use python's official Ollama client and implemented normalizers for it