Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Normalizers not always returning requests with type ChatCompletionRequest #187

Closed
#242
Closed
Normalizers not always returning requests with type ChatCompletionRequest#187
#242
Assignees
yrobla

Description

@aponcedeleonch
aponcedeleonch
opened on Dec 4, 2024

Some request normalizers are not always returning ChatCompletionRequest. This can potentially cause errors in the pipeline if we explicitly expect that type. The providers I have noticed not returning the type:

  • Ollama
  • Anthropic. translate_completion_input_params from litellm is returning a dict and not a ChatCompletionRequest as the typing of the function suggests.

Activity

  1. aponcedeleonch
    added
    bug
    Could-Have
    on Dec 4, 2024
  2. yrobla
    self-assigned this
    on Dec 9, 2024
  3. yrobla
    added 5 commits that reference this issue on Dec 10, 2024

    fix: override translate method to return ChatCompletionRequest

    e568c90

    fix: override translate method to return ChatCompletionRequest

    5c44b02

    fix: override translate method to return ChatCompletionRequest

    0b15595

    fix: override translate method to return ChatCompletionRequest

    1303e8e

    fix: override translate method to return ChatCompletionRequest

    b397a2b
  4. yrobla
    closed this as completedin #242on Dec 10, 2024
  5. yrobla
    closed this as completedin b397a2bon Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions