fix: add global debug flag to suppress traceback unless -d/--debug specified (ENG-3817)#54
Merged
goodwillstack merged 2 commits intomainfrom Feb 13, 2025
Merged
Conversation
Contributor
goodwillstack
commented
Dec 20, 2024
goodwillstack
commented
- Add very top level -d/--debug flag that will catch all the errors and will print exceptions, otherwise it will print the human friendly messages
… specified (ENG-3817)
stacklet/client/sinistral/cli.py
Outdated
| Still -d / --debug flag is valid flag we define for click so it can be used else where | ||
| """ | ||
| argv = sys.argv.copy() | ||
| argv = argv[1:] |
Contributor
There was a problem hiding this comment.
you don't really need to copy the args, since you're not changing the list?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.