Conversation
We want to start passing basic CI info such as the branch and PR number over to sinistral so our customers have additional metadata around where their results are coming from
sontek
changed the title
albertodonato
approved these changes
Oct 1, 2024
| # We don't need to record CI info for local runs. | ||
| if ci_info["service"] == "local": | ||
| ci_info = None | ||
|
|
Contributor
There was a problem hiding this comment.
the get_ci_info() call could be made in the else clause, we don't need to try to fetch them running locally
Contributor
Author
There was a problem hiding this comment.
I only know its a local run after I've called get_ci_info but I could do this logic up in that call so it returns None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to start passing basic CI info such as the branch and PR number over to sinistral so our customers have additional metadata around where their results are coming from.
This requires: https://github.com/stacklet/sinistral/pull/428