fix: sinistral backend output doesn't override run cli output selections#37
Merged
fix: sinistral backend output doesn't override run cli output selections#37
Conversation
johnsca
added a commit
that referenced
this pull request
Oct 4, 2023
The change in #37 means that the SinistralFormat class attribute will never set, so we should use the local var instead.
johnsca
added a commit
that referenced
this pull request
Oct 4, 2023
The change in #37 means that the SinistralFormat class attribute will never set, so we should use the local var instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously sinistral run output was hardcoded, allow
users to specify all supported c7n-left run options
while continuing to output to sinistral backend.
closes #36