Skip to content

feat: auto-auth with project or org creds (ENG-2669)#32

Merged
johnsca merged 4 commits intomainfrom
johnsca/feat/ENG-2669/on-demand-auth
Sep 27, 2023
Merged

feat: auto-auth with project or org creds (ENG-2669)#32
johnsca merged 4 commits intomainfrom
johnsca/feat/ENG-2669/on-demand-auth

Conversation

@johnsca
Copy link
Contributor

@johnsca johnsca commented Sep 20, 2023

Adds support to automatically use Project or Org Credentials if available in the environment to get an in-memory access token if an on-disk one is not available. This can streamline the process for headless usage in CI systems and entirely avoid the need to manage a SINISTRAL_CONFIG dir.

johnsca and others added 4 commits September 20, 2023 17:23
Adds support to automatically use Project or Org Credentials if
available in the environment to get an in-memory access token if an
on-disk one is not available. This can streamline the process for
headless usage in CI systems and entirely avoid the need to manage a
SINISTRAL_CONFIG dir.
Copy link
Contributor

@tvansteenburgh tvansteenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM, thanks @johnsca. Do we need any doc updates to go with this?

@johnsca
Copy link
Contributor Author

johnsca commented Sep 27, 2023

Yeah, I'll want to update the CI Usage docs page once this and the other related PRs land to document the streamlined suggested workflow.

@johnsca johnsca merged commit 3426548 into main Sep 27, 2023
@johnsca johnsca deleted the johnsca/feat/ENG-2669/on-demand-auth branch September 27, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants