chore: chain cy.get assertions + clicks to avoid detached-DOM flakiness#97
Merged
jtroup merged 1 commit intostacklet/integrationfrom Mar 17, 2026
Merged
chore: chain cy.get assertions + clicks to avoid detached-DOM flakiness#97jtroup merged 1 commit intostacklet/integrationfrom
jtroup merged 1 commit intostacklet/integrationfrom
Conversation
ephan
approved these changes
Mar 17, 2026
ephan
left a comment
There was a problem hiding this comment.
This is fine. It's odd to me doing a check and action in the same line. Usually we separate these for clarity although given the bug it looks like the only option.
I believe that the test would fail if the item was not visible when trying to click. So the should is probably unnecessary i.e.
cy.getByTestId("LogOutButton").click();
should behave the same as
cy.getByTestId("LogOutButton").should("be.visible").click();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Chain
.should("be.visible").click()on a singlecy.get()callinstead of issuing a separate
cy.get()for the assertion and anotherfor the interaction. Two specs affected:
visualizations/table/table_spec.js—.jvi-toggleexpand clicksuser/logout_spec.js—LogOutButtonclickwhy
When assertion and interaction use separate
cy.get()calls, a Reactre-render between the two commands can replace the DOM node. Cypress
then holds a stale reference and throws:
Per https://on.cypress.io/element-has-detached-from-dom, the fix is to
re-query and interact in one chain so Cypress never holds a reference
across a potential re-render boundary.
table_spec.jsreproduced in CIon 2026-03-14;
logout_spec.jshad the same latent pattern.testing
Covered by the existing Cypress e2e suite. The
table_spec.jsfailurewas observed in CI and no longer reproduces with this change.
docs
No docs needed.
🤖 Generated with Claude Code