Bump integrations/github to v6 by priteau · Pull Request #484 · stackhpc/stackhpc-release-train

priteau · 2026-02-26T12:05:20Z

No description provided.

gemini-code-assist · 2026-02-26T12:05:31Z

Summary of Changes

Hello @priteau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the integrations/github Terraform provider to its latest stable version. This upgrade is crucial for maintaining compatibility, accessing new functionalities, and benefiting from performance improvements and security patches offered in newer releases.

Highlights

GitHub Provider Version Bump: The integrations/github Terraform provider has been updated from version 4.28.0 to 6.11.1 in terraform/github/provider.tf.

Changelog

terraform/github/provider.tf
- Updated the github provider version from 4.28.0 to 6.11.1.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the integrations/github Terraform provider from version 4.28.0 to 6.11.1. This is a major version upgrade that introduces significant breaking changes that are not addressed in this PR. The current Terraform configuration will fail with this new provider version. I've added a critical comment on the version change, detailing the necessary changes in other files (repositories.tf, branches.tf) to make the configuration compatible with version 6.x of the provider. These changes must be implemented for the Terraform apply to succeed.

terraform/github/provider.tf

stackhpc-ci · 2026-02-27T11:35:44Z

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖`success`

Validation Output



Warning: Deprecated attribute

  on repositories.tf line 20, in resource "github_repository" "repositories":
  20:       has_downloads,

The attribute "has_downloads" is deprecated. Refer to the provider
documentation for details.
Success! The configuration is valid, but there were some validation warnings
as shown above.

Terraform Plan 📖`success`

Show Plan


undefined

Pusher: @priteau, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

priteau · 2026-02-27T12:40:45Z

Need to review the proposed Terraform changes now.

priteau · 2026-03-06T10:25:47Z

/gemini review

gemini-code-assist

Code Review

This pull request updates the Terraform configuration to be compatible with version 6 of the integrations/github provider, migrating github_branch_protection resources and ignore_changes lifecycle hooks. However, there are critical security concerns: the private and default_branch attributes were removed from the ignore_changes list without being explicitly defined, which could lead to private repositories being accidentally made public and default branches being reset to main. Additionally, I've noted significant code duplication in terraform/github/branches.tf and suggest moving the new repository configuration change to a separate PR for better focus.

terraform/github/repositories.tf

terraform/github/branches.tf

terraform/github/terraform.tfvars.json

Alex-Welsh

It looks like we are losing allow_update_branch

Set to true to always suggest updating pull request branches.

Which sounds quite useful

terraform/github/repositories.tf

Remove use of deprecated github_repository attributes: - default_branch - ignore_vulnerability_alerts_during_read - private Ignore allow_update_branch which is enabled on some repositories. Ignore has_discussions for stackhpc/ansible-collection-cephadm. Change push_restrictions to restrict_pushes. Import ansible-slurm-appliance required status checks.

priteau · 2026-03-11T11:22:20Z

It looks like we are losing allow_update_branch

Set to true to always suggest updating pull request branches.

Which sounds quite useful

We don't currently manage this setting through Terraform. I don't particularly like it since it encourages people to merge the target branch into their pull request branch instead of rebasing, which leads to a messy Git history.

I am adding it to ignore_changes for now.

priteau self-assigned this Feb 26, 2026

priteau requested a review from a team as a code owner February 26, 2026 12:05

gemini-code-assist bot reviewed Feb 26, 2026

View reviewed changes

terraform/github/provider.tf Show resolved Hide resolved

seunghun1ee previously approved these changes Feb 27, 2026

View reviewed changes

priteau dismissed seunghun1ee’s stale review via 99b976f February 27, 2026 11:00

priteau force-pushed the bump-integrations-github branch 3 times, most recently from fc18781 to 29b4ecd Compare February 27, 2026 11:27

priteau force-pushed the bump-integrations-github branch 2 times, most recently from 4e90366 to a23026d Compare February 27, 2026 11:53

priteau requested review from Alex-Welsh and seunghun1ee February 27, 2026 12:36

priteau changed the title ~~Bump integrations/github to the latest release~~ Bump integrations/github to v6 Feb 27, 2026

priteau marked this pull request as draft February 27, 2026 12:40

priteau force-pushed the bump-integrations-github branch 6 times, most recently from 3ad16be to d5bcb00 Compare March 6, 2026 10:06

gemini-code-assist bot reviewed Mar 6, 2026

View reviewed changes

terraform/github/repositories.tf Show resolved Hide resolved

terraform/github/repositories.tf Show resolved Hide resolved

terraform/github/branches.tf Show resolved Hide resolved

terraform/github/terraform.tfvars.json Show resolved Hide resolved

priteau force-pushed the bump-integrations-github branch from d5bcb00 to 2ec9db7 Compare March 6, 2026 10:39

priteau marked this pull request as ready for review March 6, 2026 10:52

Alex-Welsh reviewed Mar 11, 2026

View reviewed changes

terraform/github/repositories.tf Show resolved Hide resolved

priteau force-pushed the bump-integrations-github branch from 2ec9db7 to 5c55fe9 Compare March 11, 2026 11:20

priteau requested a review from Alex-Welsh March 11, 2026 17:08

Alex-Welsh approved these changes Mar 12, 2026

View reviewed changes

priteau merged commit 641db34 into main Mar 12, 2026
4 checks passed

priteau deleted the bump-integrations-github branch March 12, 2026 09:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump integrations/github to v6#484

Bump integrations/github to v6#484
priteau merged 1 commit intomainfrom
bump-integrations-github

priteau commented Feb 26, 2026

Uh oh!

gemini-code-assist bot commented Feb 26, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

stackhpc-ci commented Feb 27, 2026 •

edited

Loading

Uh oh!

priteau commented Feb 27, 2026

Uh oh!

priteau commented Mar 6, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alex-Welsh left a comment

Uh oh!

Uh oh!

priteau commented Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

priteau commented Feb 26, 2026

Uh oh!

gemini-code-assist bot commented Feb 26, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

stackhpc-ci commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Terraform Plan 📖success

Uh oh!

priteau commented Feb 27, 2026

Uh oh!

priteau commented Mar 6, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alex-Welsh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

priteau commented Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stackhpc-ci commented Feb 27, 2026 •

edited

Loading

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖`success`

Terraform Plan 📖`success`