Repository navigation
feat(mobile): mount ProtocolBlockScreen when protocol compat is blocked - #9780
Merged
Merged
Conversation
ProtocolBlockScreen existed since PR #1440 but was never mounted: on a 'blocked' compat verdict the only output was a console.warn, so a future MIN_COMPATIBLE_RUNTIME_CLIENT_VERSION bump would have silently shown a broken host UI instead of the update screen. Add HostProtocolGate — a choke point in app/h/_layout.tsx above every /h/[hostId] route — that consumes useHostStatusGates and replaces the blocked host's entire UI (sidebar + detail stack) with ProtocolBlockScreen. The host list and other hosts stay usable; the screen's own 'Back to hosts' escape hatch routes to '/'. Both block reasons render their respective CTAs (mobile-too-old → App Store, desktop-too-old → GitHub Releases). Compat logic stays in the src/shared mirror contract — no fork.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds host-scoped protocol compatibility gating to the mobile host layout. The gate now handles pending probes, blocked compatibility verdicts, and shared host capability state, while host screens consume the shared context. Tests cover outdated clients, compatible clients, pending connections, reconnects, unresolved probes, and failed status requests. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
Contributor
Author
This was referenced Jul 27, 2026
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
…ed (stablyai#9780) * feat(mobile): mount ProtocolBlockScreen when protocol compat is blocked ProtocolBlockScreen existed since PR stablyai#1440 but was never mounted: on a 'blocked' compat verdict the only output was a console.warn, so a future MIN_COMPATIBLE_RUNTIME_CLIENT_VERSION bump would have silently shown a broken host UI instead of the update screen. Add HostProtocolGate — a choke point in app/h/_layout.tsx above every /h/[hostId] route — that consumes useHostStatusGates and replaces the blocked host's entire UI (sidebar + detail stack) with ProtocolBlockScreen. The host list and other hosts stay usable; the screen's own 'Back to hosts' escape hatch routes to '/'. Both block reasons render their respective CTAs (mobile-too-old → App Store, desktop-too-old → GitHub Releases). Compat logic stays in the src/shared mirror contract — no fork. * fix(mobile): fence incompatible host routes efficiently * fix(mobile): route Android updates to releases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Summary
ProtocolBlockScreenwas only mounted inside the base host-list screen, so deep links and nested/h/[hostId]routes could continue into an incompatible desktop instead of showing the required update screen. This moves compatibility enforcement to the host layout choke point used by every host route.HostProtocolGateabove the full host UI (sidebar + detail stack), while the host list and other hosts remain usable.status.getgates withHostScreen, avoiding the duplicate remote probe the parent gate would otherwise add on common phone/tablet paths.mobile-too-old, GitHub Releases fordesktop-too-old.Tests
HostProtocolGate.test.tsexercises the realuseHostStatusGates→evaluateCompat→ProtocolBlockScreenwiring with only client acquisition mocked:mobile-too-oldrenders the App Store block screen and removes host contentdesktop-too-oldrenders the GitHub Releases block screen and removes host contentstatus.getVerification completed locally:
tsc --noEmit, oxlint, and oxfmt cleanScreenshots / manual QA
Manual iPhone 17 Pro simulator coverage includes current/current compatibility, both forced block reasons,
Back to hosts, a Resume deep link into a nested session route, and a final compatible-host pass after restoring the production constants.Detailed review notes and Electron boot evidence: #9780 (comment)