Repository navigation
fix(settings): stop mislabeling a WSL default shell as PowerShell - #9779
Conversation
The Terminal settings shell toggle coerced a stored `wsl.exe` default to `powershell.exe` for display, so a WSL default (set in onboarding) showed "PowerShell" selected and wrongly surfaced the PowerShell-version options. Drop the coercion and surface WSL as a disabled, already-selected segment when it's the active default, so the control reflects the real shell. WSL stays non-selectable here because choosing it needs a companion distro that only the onboarding step configures; wiring a full WSL picker into Settings is left for a deliberate design pass against the per-project runtime model.
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTerminalPane now preserves the configured Windows shell instead of converting 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ablyai#9779) * fix(settings): stop mislabeling a WSL default shell as PowerShell The Terminal settings shell toggle coerced a stored `wsl.exe` default to `powershell.exe` for display, so a WSL default (set in onboarding) showed "PowerShell" selected and wrongly surfaced the PowerShell-version options. Drop the coercion and surface WSL as a disabled, already-selected segment when it's the active default, so the control reflects the real shell. WSL stays non-selectable here because choosing it needs a companion distro that only the onboarding step configures; wiring a full WSL picker into Settings is left for a deliberate design pass against the per-project runtime model. * test(settings): cover persisted WSL shell display
Problem
On Windows, the Settings → Terminal → Default Shell toggle silently misrepresented a WSL default. If a user picked WSL during onboarding (
terminalWindowsShell = 'wsl.exe'), the Settings page:wsl.exe → powershell.exefor display (TerminalPane.tsx:60), andshowWindowsPowerShellImplementationtrue.So the setting the user actually chose was invisible here, and the page claimed a shell they weren't using.
Fix
TerminalPane.tsx— remove thewsl.exe → powershell.execoercion. The page now passes the real shell through, which both fixes the mislabel and correctly hides the PowerShell-version options for WSL users.TerminalWindowsShellSection.tsx— surface WSL as a disabled, already-selected segment when it's the active default (mirroring the existing Git Bashdisabledpattern). The segmented control renders a disabled+active option with the selected styling, so the toggle now tells the truth. Users can still switch away to PowerShell/cmd.Reuses the existing
b637dd57a7: "WSL"i18n key (already translated in all 5 locales) — no new string.Deliberately out of scope
WSL is not made selectable from this toggle. Choosing WSL requires a companion distro (
terminalWindowsWslDistro) that only the onboarding step configures, and WSL was intentionally modeled as a per-project runtime + onboarding concept in #5519. Wiring a full WSL picker (with distro selection) into Settings needs a design pass to reconcile the global-default / project-runtime / onboarding surfaces — tracked separately, not patched here.Verification
oxlintclean on both filestsc --noEmit(web project) passesverify:localization-catalogpasses (key parity across en/es/ja/ko/zh)