Skip to content

fix(mobile): stop pairing QR column from starving CJK copy (#9700) - #9711

Merged
OrcaWin merged 1 commit into
stablyai:mainfrom
OrcaWin:OrcaWin/bug-windows-application-qrcode-page-wrong
Jul 21, 2026
Merged

OrcaWin merged 1 commit into
stablyai:mainfrom
OrcaWin:OrcaWin/bug-windows-application-qrcode-page-wrong

Conversation

@OrcaWin

@OrcaWin OrcaWin commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #9700 — Windows Mobile pairing step laid out CJK copy one glyph per line because the QR column used auto and grew to the max-content width of the long relay-degraded notice under the QR, starving the copy column.

  • Pin step + pairing QR grid tracks to --mp-qr-large-size (shared with the QR box)
  • Constrain .mp-qr-stack children so under-QR copy wraps inside the fixed track
  • Wrap the degraded-notice text in a min-w-0 flex item
  • Lock the CSS contract + notice structure in unit tests

Test plan

  • pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/assets/mobile-page-qr-layout.test.ts src/renderer/src/components/mobile/MobileHero.test.tsx
  • Manually: Mobile page → Get started → Continue to pair, zh locale, force relay-degraded notice — copy column multi-glyph wrap, notice wraps under QR

…9700)

Pin the large-QR grid track to a shared size token so long under-QR copy
(relay-degraded notice) cannot max-content the auto column and collapse
the pairing step to one glyph per line. Constrain the QR stack for wrap
and lock the layout contract in tests.
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 60bba81d-fc0d-48af-8831-8cb7537014f5

📥 Commits

Reviewing files that changed from the base of the PR and between 18b7aa3 and 51e3879.

📒 Files selected for processing (4)
  • src/renderer/src/assets/mobile-page-qr-layout.test.ts
  • src/renderer/src/assets/mobile-page.css
  • src/renderer/src/components/mobile/MobileHero.test.tsx
  • src/renderer/src/components/mobile/MobileHero.tsx

📝 Walkthrough

Walkthrough

The mobile page now uses a shared 184px QR size token for QR tiles and the right columns of step-two and pairing grids. QR stack and pairing elements receive width constraints to support shrinking and prevent overflow. The degraded relay notice adds w-full and min-w-0 classes, with its text wrapped in a shrinkable span. Tests cover the CSS layout rules and the notice’s updated DOM classes and text.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers summary and testing, but it omits required Screenshots, AI Review Report, Security Audit, and Notes sections. Add the missing template sections, including screenshots or 'No visual change', AI review, security audit, and notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main fix: preventing the pairing QR column from starving CJK copy in the mobile flow.
Linked Issues check ✅ Passed The CSS and test changes directly fix the Windows Mobile QR layout bug described in #9700.
Out of Scope Changes check ✅ Passed All changes stay focused on the mobile QR layout fix and its regression tests, with no unrelated code paths introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@OrcaWin
OrcaWin merged commit 7cf052b into stablyai:main Jul 21, 2026
2 checks passed
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
…9700) (stablyai#9711)

Pin the large-QR grid track to a shared size token so long under-QR copy
(relay-degraded notice) cannot max-content the auto column and collapse
the pairing step to one glyph per line. Constrain the QR stack for wrap
and lock the layout contract in tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: windows application qrcode page wrong

1 participant