Repository navigation
fix(dashboard-popout): keep moving card under the open terminal - #9709
Merged
Merged
Conversation
The card column-move uses the View Transitions API, whose snapshot pseudo-elements render in the browser top layer — above any z-index, including the terminal dialog's z-50 Radix portal. So a card morphing columns briefly flickered over the open terminal. Skip the view transition while the terminal dialog is open; the card just settles into its new column under the dialog (which covers the board anyway) instead of animating on top.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds detection for open terminal dialogs in dashboard snapshot handling. When such a dialog exists, snapshot updates use direct state assignment instead of a View Transition. Adds tests covering View Transition activation when a card changes columns and direct snapshot updates when an open dialog is present. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 27, 2026
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
…lyai#9709) The card column-move uses the View Transitions API, whose snapshot pseudo-elements render in the browser top layer — above any z-index, including the terminal dialog's z-50 Radix portal. So a card morphing columns briefly flickered over the open terminal. Skip the view transition while the terminal dialog is open; the card just settles into its new column under the dialog (which covers the board anyway) instead of animating on top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Orca Agent Dashboard popout, when an agent card moves between columns (a status change) while the terminal dialog is open, the card briefly flickers above the terminal during the transition. It should stay under it.
Root cause
The card column-move animates via the View Transitions API (
document.startViewTransitioninuseDashboardSnapshot.ts, per-cardview-transition-nameinAgentKanbanCard.tsx). While a transition runs, the browser renders the card's snapshot pseudo-elements (::view-transition-group/old/new) in the document's real top layer — which paints above anyz-index.The terminal is a Radix
Dialogrendered through a portal atz-50(a plain portal, not a native top-layer element). So a card morphing columns paints its snapshot over thez-50dialog — the flicker. Noz-indexon the dialog can beat the top layer.Fix
Skip the view transition while the terminal dialog is open (detected via
[role="dialog"][data-state="open"]). The card just settles into its new column under the dialog — which covers the board anyway, so the motion isn't where the user is looking — instead of animating on top. Non-dialog moves are unchanged and still animate.The check lives in the hook rather than threading dialog state up through
DashboardPopoutRoot, because the conflict is fundamentally "is a top-layer-competing dialog visible right now" — a rendering fact best read at transition time, and it keepsopenedCardstate owned by the board.Test
New
useDashboardSnapshot.test.tsx:All 16 dashboard-popout tests pass; oxlint clean.
Trade-off
The moved card now jumps under the terminal rather than animating. That's intended — a clipped-beneath animation isn't achievable with the top-layer View Transition and would need a different animation approach for the board.