Skip to content

fix(dashboard-popout): keep moving card under the open terminal - #9709

Merged
brennanb2025 merged 1 commit into
mainfrom
brennanb2025/fix-agent-dashboard-terminal
Jul 21, 2026
Merged

brennanb2025 merged 1 commit into
mainfrom
brennanb2025/fix-agent-dashboard-terminal

Conversation

@brennanb2025

Copy link
Copy Markdown
Contributor

Problem

In the Orca Agent Dashboard popout, when an agent card moves between columns (a status change) while the terminal dialog is open, the card briefly flickers above the terminal during the transition. It should stay under it.

Root cause

The card column-move animates via the View Transitions API (document.startViewTransition in useDashboardSnapshot.ts, per-card view-transition-name in AgentKanbanCard.tsx). While a transition runs, the browser renders the card's snapshot pseudo-elements (::view-transition-group/old/new) in the document's real top layer — which paints above any z-index.

The terminal is a Radix Dialog rendered through a portal at z-50 (a plain portal, not a native top-layer element). So a card morphing columns paints its snapshot over the z-50 dialog — the flicker. No z-index on the dialog can beat the top layer.

Fix

Skip the view transition while the terminal dialog is open (detected via [role="dialog"][data-state="open"]). The card just settles into its new column under the dialog — which covers the board anyway, so the motion isn't where the user is looking — instead of animating on top. Non-dialog moves are unchanged and still animate.

The check lives in the hook rather than threading dialog state up through DashboardPopoutRoot, because the conflict is fundamentally "is a top-layer-competing dialog visible right now" — a rendering fact best read at transition time, and it keeps openedCard state owned by the board.

Test

New useDashboardSnapshot.test.tsx:

  • a column change runs the transition normally;
  • a column change with a dialog open in the DOM skips the transition but still applies the snapshot (the card must still land in its new column, just without the animation).

All 16 dashboard-popout tests pass; oxlint clean.

Trade-off

The moved card now jumps under the terminal rather than animating. That's intended — a clipped-beneath animation isn't achievable with the top-layer View Transition and would need a different animation approach for the board.

The card column-move uses the View Transitions API, whose snapshot
pseudo-elements render in the browser top layer — above any z-index,
including the terminal dialog's z-50 Radix portal. So a card morphing
columns briefly flickered over the open terminal.

Skip the view transition while the terminal dialog is open; the card
just settles into its new column under the dialog (which covers the
board anyway) instead of animating on top.
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7641cc02-4f38-49cd-aa6e-c5f57b60db1b

📥 Commits

Reviewing files that changed from the base of the PR and between 58bcfe2 and ec74739.

📒 Files selected for processing (2)
  • src/renderer/src/components/dashboard-popout/useDashboardSnapshot.test.tsx
  • src/renderer/src/components/dashboard-popout/useDashboardSnapshot.ts

📝 Walkthrough

Walkthrough

Adds detection for open terminal dialogs in dashboard snapshot handling. When such a dialog exists, snapshot updates use direct state assignment instead of a View Transition. Adds tests covering View Transition activation when a card changes columns and direct snapshot updates when an open dialog is present.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning It explains the bug and fix, but it misses the required template sections for Summary, Screenshots, Testing, AI Review Report, Security Audit, and Notes. Rewrite the description using the repository template and add the missing sections, including screenshots or No visual change, test checklist, AI review report, security audit, and notes.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, specific, and accurately describes the main dashboard-popout fix.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brennanb2025
brennanb2025 merged commit 16074b2 into main Jul 21, 2026
2 checks passed
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
…lyai#9709)

The card column-move uses the View Transitions API, whose snapshot
pseudo-elements render in the browser top layer — above any z-index,
including the terminal dialog's z-50 Radix portal. So a card morphing
columns briefly flickered over the open terminal.

Skip the view transition while the terminal dialog is open; the card
just settles into its new column under the dialog (which covers the
board anyway) instead of animating on top.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant