[brennanb2025]

What

Fixes the action hierarchy of the Linear agent-skill install modal. Neil + Brennan flagged that the dismiss button read as the primary CTA and got reflexively clicked.

Changes

• Install CLI & Skill → filled primary (default). Added an opt-in installVariant prop to AgentSkillSetupPanel (defaults to outline, so settings surfaces are untouched); the Linear modal passes default.
• Removed the footer dismiss buttons. The footer is gone entirely, so Install is the only labeled action.
• Permanent opt-out → a quiet EyeOff icon next to the ×, matching the house pattern for hiding a setup/teaching surface (SetupGuideModal, StatusBarUsageEmptyCta, SetupGuideSidebarEntry). The two "make it go away" controls now sit together — × = dismiss for the session, ⊘ EyeOff = don't show again — and neither is a tempting text button.
• Initial focus lands on Install (the EyeOff renders last in the branch) so Enter-on-open can't permanently dismiss. Wrapped in a local TooltipProvider so it works in isolated mounts/tests.

Testing

• LinearAgentSkillSetupPrompt.test.tsx: 27/27 pass (× → session snooze; EyeOff → permanent dismiss, located by aria-label).
• Electron QA: mounted the real dialog in the running app — verified Install=default, EyeOff present (aria "Don't show again"), no footer, and initial focus = Install (not the hide button). Screenshot above.
• tsc (web) + oxlint clean; all 5 locale JSONs validate.

Note: the modal also auto-opens on the first activation of a Linear-linked worktree with the skill missing (not only via the reminder toast's "Set up"). For that path the × (session) and the EyeOff (permanent) cover dismissal.

[coderabbitai]

📝 Walkthrough

Walkthrough

The installer setup panel now accepts an optional button variant, defaults to outline, and applies it to its install or update CTA. The Linear setup dialog passes the default variant, removes its session-only “Not now” action, and retains permanent dismissal. Modal close handling now performs session snoozing, with corresponding test and localization updates.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	It includes a summary and testing, but it omits required AI Review Report, Security Audit, and explicit Notes sections from the template.	Add the missing template sections: AI Review Report, Security Audit, and Notes, and describe the cross-platform review and any follow-up risks.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	It accurately summarizes the main change: reworking the Linear skill-install modal's CTA hierarchy.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[brennanb2025]

⚠️ Superseded — see the revised design comment and the PR description.
This first pass removed "Not now". We reverted that: because the modal auto-opens unsolicited, the reflexive dismiss must stay non-destructive, so "Not now" is kept (quiet ghost = session snooze) and "Don't show again" is demoted to a muted link. The screenshots below are outdated.

---

Electron QA — visible modal render

Launched the dev build on this branch (brennanb2025/skill-install-decline-default, CDP-attached, verified instance identity) and rendered the real LinearAgentSkillSetupDialog to confirm the shipped CTA hierarchy on screen.

Dialog close-up:

Full app window:

What the render confirms

• "Install CLI & Skill" is now the filled primary (data-variant="default") — it visually reads as the action.
• "Not now" is gone. Footer holds only the quiet ghost "Don't show again"; the dialog × still handles the session snooze.
• Re-check stays a muted ghost button.

DOM assertion from the running app:

{"buttons":[{"text":"Install CLI & Skill","variant":"default"},{"text":"Re-check","variant":"ghost"},{"text":"Don't show again","variant":"ghost"},{"text":"Close","variant":null}],"hasNotNow":false,"hasDontShow":true,"hasInstall":true}

Honesty note on method

This dev profile had no Linear-linked worktree, and the modal is gated on isActive && worktree.linkedLinearIssue + missing skill, so I mounted the real, unmodified LinearAgentSkillSetupDialog component (same React instance as the app, real CSS/theme) rather than driving the full product flow to reach it. The styling/hierarchy shown is the genuine component output; the trigger path (link a Linear ticket → skill missing) was not exercised here.

[brennanb2025]

⚠️ Superseded — see the final comment and the PR description. "Not now" was ultimately removed; the × handles session dismiss. Screenshot below is outdated.

---

Design update — safe reflexive dismiss (revised from the first pass)

Since this modal auto-opens unsolicited, the earlier "just remove Not now" pass had a side effect: it left permanent "Don't show again" as the only labeled footer button — i.e. the reflexive dismiss became the destructive one, nuking a useful prompt forever.

Revised layout (verified live in the running app):

• Install CLI & Skill — filled primary (data-variant="default")
• Not now — quiet ghost, footer-right = the easy/safe reflexive dismiss (session snooze)
• Don't show again — muted link, footer-left = permanent, takes intent
• × — still snoozes for the session

Live DOM assertion:

{"buttons":[{"text":"Install CLI & Skill","variant":"default"},{"text":"Re-check","variant":"ghost"},{"text":"Don't show again","variant":"link"},{"text":"Not now","variant":"ghost"},{"text":"Close","variant":null}]}

Full app window

Method note: this dev profile had no Linear-linked worktree, so I mounted the real, unmodified LinearAgentSkillSetupDialog (same React instance + CSS as the app) rather than driving the full link-ticket flow. Styling/hierarchy shown is genuine component output.

[brennanb2025]

⚠️ Superseded — see the latest comment and the PR description. The permanent opt-out moved from a footer link to an EyeOff icon next to the ×. Screenshot below is outdated.

---

Final: "Not now" removed

Landed on removing "Not now" entirely — the modal is normally opened by clicking "Set up" on the reminder toast (opt-in), and the dialog × already covers session dismiss, so it was redundant.

Live DOM from the running app:

{"buttons":[{"text":"Install CLI & Skill","variant":"default"},{"text":"Re-check","variant":"ghost"},{"text":"Don't show again","variant":"link"},{"text":"Close","variant":null}],"hasNotNow":false}

• Install CLI & Skill — filled primary
• Don't show again — quiet muted link (permanent opt-out)
• × — session dismiss

Supersedes the earlier "keep Not now" comment.

[brennanb2025]

Update — permanent opt-out is now an EyeOff icon (no footer)

Replaced the muted "Don't show again" footer link with a quiet EyeOff icon button next to the ×, matching the house pattern for hiding a setup surface (SetupGuideModal et al.). Footer is gone — Install is the only labeled action.

• **× ** = dismiss for the session · ⊘ EyeOff = don't show again (tooltip + aria-label)
• Initial focus lands on Install (EyeOff renders last) so Enter-on-open can't nuke it.

Live-verified in the app: activeElement on open = "Install CLI & Skill". Supersedes the earlier layouts on this PR.

[brennanb2025]

Nit fix — EyeOff now pixel-aligned with the ×

The hide icon sat 2px low (its icon-xs button is 24px tall vs the bare 16px × close). Nudged top-3.5→top-3; both icon centers now measure Y=433 in the running app.