Repository navigation
Conversation
Contributor
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.grok/binin the packaged macOS process PATH alongside the existing agent-specific fallback install directories.Screenshots
No visual change.
Testing
pnpm lintpnpm typecheckpnpm testpnpm buildAI Review Report
Targeted review checked that the fallback is limited to packaged macOS startup, uses the existing home-directory lookup and
path.join, and does not change Linux/Windows launch behavior.git diff --checkand TypeScript type checking passed. Cross-platform/SSH review confirmed there are no hard-coded separators, shortcuts, labels, or remote-host command changes.Security Audit
The change adds a fixed user-local binary directory to the same existing PATH fallback list; it adds no shell interpolation, command execution, auth, secrets, dependency, or writable path. The path is derived from Electron's home directory and joined with Node path utilities.
Notes
ELI5
Grok installed under ~/.grok/bin was invisible to GUI-launched Orca on macOS because that path was not on Electron's PATH. The preflight PATH now includes that folder so Grok is detected.