Skip to content

fix(codex): strip Orca-owned hook trust before mirroring config into managed homes (PR-A) - #9173

Closed
brennanb2025 wants to merge 2 commits into
brennanb2025/codex-home-consolidationfrom
brennanb2025/codex-ma-a-config-hygiene
Closed

brennanb2025 wants to merge 2 commits into
brennanb2025/codex-home-consolidationfrom
brennanb2025/codex-ma-a-config-hygiene

Conversation

@brennanb2025

Copy link
Copy Markdown
Contributor

What and why

Sanitize canonical Codex config before mirroring it into managed account homes. Orca-owned hook trust is identified with the existing expected-hash and grant-ledger ownership rules and removed from the mirrored bytes, while genuine user-authored hook trust is preserved.

This prevents real-home hook trust from referencing the wrong hooks.json path/hash in every managed account home and addresses user-case matrix rows 3 and 5.

Verification

  • npx vitest run --config config/vitest.config.ts src/main/codex-accounts/service.test.ts — 25 passed
  • trust/reconciliation regression suites — 156 passed across config-toml-trust, real-home install, trust grant, and WSL runtime tests
  • pnpm run typecheck:node — passed
  • targeted oxlint — passed
  • pnpm run check:max-lines-ratchet — passed

Guardrails

  • Tests use sandboxed temporary home and user-data directories only; the real ~/.codex is never read or mutated.
  • Canonical config and its grant ledger remain unchanged; sanitization is content-only before the ownership-marked managed-home atomic write.
  • Flag-OFF behavior is unchanged.
  • No merge or approval actions are included.

@brennanb2025

Copy link
Copy Markdown
Contributor Author

Closing as superseded: #9501 (real-home routing + self-contained multi-account homes) explicitly lists this draft as superseded in its description, and that consolidation merged and shipped in v1.4.149 stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant