Repository navigation
fix(gitlab): render item descriptions and comments with document markdown variant - #9161
Merged
nwparker merged 1 commit intoJul 27, 2026
Merged
Conversation
Contributor
|
thanks for the PR. looking forward to reviewing it soon |
…down variant The GitLab issue/MR dialog rendered its description and comment bodies with the compact CommentMarkdown variant, which collapses headings to inline bold spans and paragraphs to inline spans — so multi-section issue descriptions ran together as a wall of text. Switch both surfaces to the document variant (with the same typography classes the GitHub dialog already uses) so headings regain size hierarchy and block spacing. Add CommentMarkdown tests asserting the document variant renders headings as block elements while the compact variant flattens them, guarding against a regression of exactly this bug. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
SilvaViniF
force-pushed
the
fix/gitlab-item-markdown-rendering
branch
from
July 19, 2026 11:23
daa424a to
818425c
Compare
SilvaViniF
marked this pull request as ready for review
July 19, 2026 11:43
Contributor
📝 WalkthroughWalkthroughGitLab comments and work item descriptions now render with 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nwparker
requested review from
AmethystLiang
and removed request for
brennanb2025
July 26, 2026 21:00
Contributor
|
@AmethystLiang need your stamp |
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
…down variant (stablyai#9161) Co-authored-by: viniciussilva <vinicius.silva@plus10.de> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitLab issue/MR descriptions and comments rendered as a single wall of text: Markdown headings (
## Problem to solve,## Proposed solution, …) lost their size hierarchy and block spacing, so every section ran into the next paragraph.This switches both surfaces to
variant="document"with the same typography classes the GitHub item dialog already uses.Screenshots
Real Orca GitLab item dialog captures via Electron CDP (
agent-browser/ Playwright over--remote-debugging-port). Same live dialog surface this PR changes (GitLabItemDialog→CommentMarkdown).Issues created on
gitlab.com/neil148/testso each fixture exercises a different markdown shape.1. GitLab default issue template
Headings like Problem to solve run into the following paragraph before; after they get real block hierarchy + spacing.
2. Heading hierarchy (h1–h4)
3. Lists, tasks, and code
4. GFM table + blockquote
5. Dense multi-section body
Window context
Testing
pnpm lint— clean for the changed filespnpm typecheckpnpm test—CommentMarkdown.test.tsxpasses (20 tests)pnpm buildCommentMarkdowncases asserting the document variant renders headings as block<h2>while the compact variant does not — a direct regression guard for this bug.AI Review Report
Security Audit
comment.body/details.bodywere already fetched from GitLab and already rendered throughCommentMarkdownbefore this change.compactanddocumentvariants run the identical pipeline (rehypeRaw→rehypeSanitizewith the shared schema). Thedocumentvariant does not relax sanitization, so the XSS posture is unchanged.Notes
No platform-specific behavior. Scope is a single topic (GitLab item dialog markdown rendering); no unrelated changes.
ELI5
GitLab issue and MR descriptions rendered as one flat wall of text — headings lost size and spacing. They now use the same document markdown styling as GitHub items so sections are readable.