[brennanb2025]

What

Makes the release-cut workflow regenerate the bundled skill manifest whenever it bumps the version, so resources/skills/current-manifest.json can never again drift behind package.json.

Why

The "Bump package.json and tag" step in release-cut.yml runs npm version … but only staged package.json. It never regenerated the skill manifest, whose appVersion is derived from package.json. So every cut left the committed manifest pointing at the previous release.

This shipped in v1.4.144-rc.1, rc.2, and rc.3 — all three carried an appVersion: 1.4.144-rc.1 manifest against an ever-newer package.json. Because verify:skill-bundle-manifest runs inside pnpm run lint and as the .github/workflows/pr.yml verify job, the stale manifest turns that check red on every branch after a cut until someone regenerates by hand (which is what #9082 did as a one-off for rc.2).

Runtime impact was nil — appVersion is a provenance label, not used for freshness classification — but the CI breakage is real and recurring.

Fix

Regenerate the manifest right after npm version and stage resources/skills into the release commit:

npm version "$VERSION" --no-git-tag-version --allow-same-version
node config/scripts/generate-skill-bundle-manifest.mjs --write
git add package.json resources/skills

• The generator is dependency-free (only node: builtins + git), so it runs in the cut job without a pnpm install (the job never installs deps).
• The step's fetch-depth: 0 checkout gives the generator the full tag history it reads for the release mapping (also fixes the shallow-checkout assertReleasedHistoryPreserved failure noted during the audit).
• The existing git diff --cached --quiet / empty-commit branch still works: on a normal cut both package.json and the manifest change; on a re-cut of the same version it self-heals a stale manifest into the commit.

Verification

Simulated the cut sequence in a worktree at current main:

Step	verify:skill-bundle-manifest
baseline (main, post-#9082)	exit 0
after npm version 1.4.144-rc.99 (bump, no regen)	exit 1 — reproduces the shipped bug
after node config/scripts/generate-skill-bundle-manifest.mjs --write (new step)	manifest appVersion → 1.4.144-rc.99, exit 0

Workflow YAML parses cleanly. No product code changed.

Found during the v1.4.144 RC release audit — this is the root-cause fix behind the stale-manifest P1 (the per-tag symptom was patched by #9082).

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 34e63806-a67f-42c9-a9c0-d0d745734449

📥 Commits

Reviewing files that changed from the base of the PR and between e4f8d82 and e9e571b.

📒 Files selected for processing (1)

• config/scripts/package-electron-runtime-contract.test.mjs

---

📝 Walkthrough

Walkthrough

The release cut workflow now regenerates the bundled skill manifest after bumping the package version and stages both package.json and resources/skills. Contract tests verify the command ordering and retry behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description has useful details, but it misses required template sections like Screenshots, Testing, AI Review Report, Security Audit, and Notes.	Reformat the PR description to the repository template and add the missing sections, including testing, AI review, security audit, and notes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the main change: regenerating the skill manifest during the release-cut version bump.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}