Repository navigation
fix(browser): place CLI-created tabs in the active browser tab's group - #904
Merged
Merged
Conversation
When an agent creates a browser tab via `orca tab create`, it lands in the terminal's tab group (the UI-active group) instead of alongside existing browser tabs. Use `activeBrowserTabIdByWorktree` to resolve the correct group, falling back to the active group when no browser tab exists. Closes #116
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orca tab create, the tab now lands in the same tab group as the active browser tab instead of the terminal's grouptargetGroupIdoption toCreateBrowserTabOptionsand threads it through tocreateUnifiedTabContext
Feedback from Slack: when the AI opens a new browser tab via the CLI, it ends up in the terminal's tab group instead of alongside existing browser tabs.
Root cause:
createUnifiedTabdefaults toactiveGroupIdByWorktree(the UI-focused group), which is the terminal's group when an agent is running.Fix: In the CLI IPC handler (
onRequestTabCreate), look up the active browser tab viaactiveBrowserTabIdByWorktreeand pass itsgroupIdastargetGroupId. Only the CLI path is affected — Cmd+T, right-click open, terminal links, and session restore are unchanged.Closes #116
Test plan
targetGroupIdroutes to correct group, omitting it falls back to active grouporca tab create --url <url>while terminal group is active → new tab should appear in the browser group