Skip to content

fix: route Cmd/Ctrl+N through main-process shortcut allowlist - #895

Merged
AmethystLiang merged 1 commit into
mainfrom
can-t-directly-cmd-n-from-a-markdown-preview-fil
Apr 21, 2026
Merged

AmethystLiang merged 1 commit into
mainfrom
can-t-directly-cmd-n-from-a-markdown-preview-fil

Conversation

@AmethystLiang

Copy link
Copy Markdown
Contributor

Problem

Cmd/Ctrl+N to open the new-workspace composer was handled only in the renderer's window-level keydown listener. This meant it didn't fire when focus was inside a contentEditable surface (markdown rich editor preview) or a browser-guest webContents, both of which bypass the renderer's normal keyboard event propagation.

Solution

Move Cmd/Ctrl+N handling into the main-process before-input-event allowlist (alongside other global shortcuts like Cmd+B, Cmd+L, Cmd+P) so it fires globally and reaches the renderer via IPC even when focus is in those special contexts.

The repo-guard logic (only open when at least one git repo is configured) is preserved by moving the check into the IPC handler in useIpcEvents.ts.

Ensures the new-workspace composer opens even when focus is inside a
contentEditable surface (markdown rich editor) or a browser-guest
webContents, both of which bypass the renderer's window-level keydown.
@AmethystLiang
AmethystLiang merged commit 8995433 into main Apr 21, 2026
2 checks passed
@AmethystLiang
AmethystLiang deleted the can-t-directly-cmd-n-from-a-markdown-preview-fil branch April 21, 2026 17:32
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
…ai#895)

Ensures the new-workspace composer opens even when focus is inside a
contentEditable surface (markdown rich editor) or a browser-guest
webContents, both of which bypass the renderer's window-level keydown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant