Repository navigation
fix: route Cmd/Ctrl+N through main-process shortcut allowlist - #895
Merged
AmethystLiang merged 1 commit intoApr 21, 2026
Merged
Conversation
Ensures the new-workspace composer opens even when focus is inside a contentEditable surface (markdown rich editor) or a browser-guest webContents, both of which bypass the renderer's window-level keydown.
AmethystLiang
deleted the
can-t-directly-cmd-n-from-a-markdown-preview-fil
branch
April 21, 2026 17:32
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
…ai#895) Ensures the new-workspace composer opens even when focus is inside a contentEditable surface (markdown rich editor) or a browser-guest webContents, both of which bypass the renderer's window-level keydown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cmd/Ctrl+N to open the new-workspace composer was handled only in the renderer's window-level keydown listener. This meant it didn't fire when focus was inside a contentEditable surface (markdown rich editor preview) or a browser-guest webContents, both of which bypass the renderer's normal keyboard event propagation.
Solution
Move Cmd/Ctrl+N handling into the main-process before-input-event allowlist (alongside other global shortcuts like Cmd+B, Cmd+L, Cmd+P) so it fires globally and reaches the renderer via IPC even when focus is in those special contexts.
The repo-guard logic (only open when at least one git repo is configured) is preserved by moving the check into the IPC handler in useIpcEvents.ts.