Skip to content

Separate mobile host card metadata - #8819

Merged
Jinwoo-H merged 1 commit into
mainfrom
Jinwoo-H/mobile-host-card-metadata
Jul 15, 2026
Merged

Jinwoo-H merged 1 commit into
mainfrom
Jinwoo-H/mobile-host-card-metadata

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Jul 15, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • keep connection state and transport path on one stable line
  • move worktree and active counts to a dedicated secondary row
  • align the new row beneath the status text and truncate each row independently on narrow screens

Why

Adding Orca Relay to the connection label made the single metadata string wrap unpredictably when desktop worktree counts were large. Separating connection state from desktop inventory restores a clear hierarchy without shrinking text or hiding the Relay path.

Validation

  • staged-file oxlint and React Doctor lint passed
  • staged-file formatting passed
  • git diff check passed
  • broader typecheck and localization checks intentionally deferred pending product-owner visual approval

Made with Orca 🐋

Co-authored-by: Orca <help@stably.ai>
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

MobileHostCard now derives a pluralized worktree summary from worktree counts, including active worktrees when present. The summary renders in a separate metadata text element only for connected hosts, while verdict and path information retains error-state coloring. Metadata layout styles were updated to support the separated text elements and flexible sizing.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the change and validation, but it does not follow the required template sections. Add the required Summary, Screenshots, Testing, AI Review Report, Security Audit, and Notes sections, and explicitly confirm cross-platform compatibility review.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: splitting mobile host card metadata into separate rows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
mobile/src/components/MobileHostCard.tsx (1)

22-24: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Enhance readability of the worktree summary string.

The inline template literal logic is functionally correct but quite dense. Consider extracting the logic into intermediate variables to improve readability and maintainability.

♻️ Proposed refactor
-  const worktreeSummary = props.worktreeCounts
-    ? `${props.worktreeCounts.total} worktree${props.worktreeCounts.total === 1 ? '' : 's'}${props.worktreeCounts.active > 0 ? ` · ${props.worktreeCounts.active} active` : ''}`
-    : null
+  let worktreeSummary = null
+  if (props.worktreeCounts) {
+    const { total, active } = props.worktreeCounts
+    const suffix = active > 0 ? ` · ${active} active` : ''
+    worktreeSummary = `${total} worktree${total === 1 ? '' : 's'}${suffix}`
+  }

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b2c90c6b-ed4a-4165-9c07-ef4d71830983

📥 Commits

Reviewing files that changed from the base of the PR and between 2519e51 and 3560690.

📒 Files selected for processing (1)
  • mobile/src/components/MobileHostCard.tsx

@Jinwoo-H
Jinwoo-H merged commit 7baaf19 into main Jul 15, 2026
3 checks passed
@Jinwoo-H
Jinwoo-H deleted the Jinwoo-H/mobile-host-card-metadata branch July 15, 2026 05:36
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
Co-authored-by: Orca <help@stably.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant