Repository navigation
Fix tooltip for draw - #8812
Merged
Merged
Fix tooltip for draw#8812
Conversation
- Replace the force-open Tooltip discovery hint with a Popover (title, body, Try it/Got it actions) that can be dismissed via outside click, Escape, or window blur — Radix's tooltip couldn't handle Electron webview clicks, which never reach the renderer document. - Gate the hint on a new `surfaceActive` prop so it only opens for the visible pane, preventing a portaled layer from anchoring against a hidden/zero-size trigger at the viewport origin. - Add locale strings for the new badge/try/dismiss copy across all supported languages and cover the hook's eligibility/dismiss behavior with unit tests.
Contributor
📝 WalkthroughWalkthroughThe markup draw button now requires active-surface state and uses it with the persisted hint hook to control an interactive discovery popover. The popover includes localized badge text, instructions, dismissal, and try actions; tooltip labeling remains available, and blur or ineligible states dismiss the hint. Remote runtime and local webview toolbars provide the active-surface state. Tests cover eligibility, dismissal, and persistence behavior, while English, Spanish, Japanese, Korean, and Chinese translations add the new hint strings. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
…isi (stablyai#8812) - Replace the force-open Tooltip discovery hint with a Popover (title, body, Try it/Got it actions) that can be dismissed via outside click, Escape, or window blur — Radix's tooltip couldn't handle Electron webview clicks, which never reach the renderer document. - Gate the hint on a new `surfaceActive` prop so it only opens for the visible pane, preventing a portaled layer from anchoring against a hidden/zero-size trigger at the viewport origin. - Add locale strings for the new badge/try/dismiss copy across all supported languages and cover the hook's eligibility/dismiss behavior with unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix tooltip for the "draw" button dispaly
Screenshots
No visual change.Testing
pnpm lintpnpm typecheckpnpm testpnpm buildAI Review Report
Summarize the code review you ran with your AI coding agent. Include the main risks it checked, what it flagged, and what you changed or verified as a result.
Confirm that the review explicitly checked cross-platform compatibility for macOS, Linux, and Windows, including shortcuts, labels, paths, shell behavior, and any Electron-specific platform differences touched by this PR.
Security Audit
Provide a basic security audit summary from your AI coding agent. Call out any input handling, command execution, path handling, auth, secrets, dependency, or IPC risks that were reviewed, plus any follow-up needed.
Notes
Call out any platform-specific behavior, risks, or follow-up work.