Skip to content

fix(ssh): resolve complete remote Node/npm toolchains - #8724

Closed
Jinwoo-H wants to merge 4 commits into
mainfrom
Jinwoo-H/bug-8450-ssh-node-npm-toolchain
Closed

Jinwoo-H wants to merge 4 commits into
mainfrom
Jinwoo-H/bug-8450-ssh-node-npm-toolchain

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • require Node and npm to be runnable from the same remote toolchain directory
  • skip incomplete system installations and continue to guarded NVM candidates
  • preserve login-shell, version-manager, cancellation, and session-limit behavior
  • add a live Ubuntu SSH/PTY regression harness for issue [Bug]: SSH relay selects system Node without npm instead of complete NVM toolchain #8450
  • add the reviewed relay runtime distribution plan and living implementation checklist as a separate documentation commit

Fixes #8450

Verification

  • pnpm exec vitest run --config config/vitest.config.ts src/main/ssh/ssh-remote-node-resolution.test.ts (32/32)
  • pnpm exec vitest run --config config/vitest.config.ts src/main/ssh/ssh-remote-node-toolchain-resolution.test.ts (8/8)
  • native-deps, versioned-install, deploy, cross-version isolation, and platform-detection focused suites (70/70)
  • pnpm run typecheck
  • pnpm run lint
  • pnpm run check:max-lines-ratchet
  • touched-file oxfmt --check
  • pnpm run test:e2e:ssh-node-toolchain-resolution (Ubuntu 24.04 arm64 Docker SSH, guarded NVM selection, relay launch, PTY round-trip)

Scope

This draft contains Milestone 0 only. It does not enable or implement bundled relay runtime distribution. Existing SSH relay behavior remains the production path.

Made with Orca 🐋

Jinwoo-H and others added 4 commits July 14, 2026 06:28
Co-authored-by: Orca <help@stably.ai>
Co-authored-by: Orca <help@stably.ai>
Co-authored-by: Orca <help@stably.ai>
Co-authored-by: Orca <help@stably.ai>
@Jinwoo-H
Jinwoo-H force-pushed the Jinwoo-H/bug-8450-ssh-node-npm-toolchain branch 2 times, most recently from 1f220a7 to 9a8f98f Compare July 17, 2026 02:44
@nwparker

nwparker commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Closing as superseded — the linked issue(s) for this PR were fixed by another change that has already been merged.

Superseding merge: #9165

Thank you for the contribution! If anything remains unaddressed, please open a new issue or PR against current main.

@nwparker nwparker closed this Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SSH relay selects system Node without npm instead of complete NVM toolchain

2 participants