Skip to content

Consolidate diff header tooltip providers - #8429

Merged
brennanb2025 merged 1 commit into
mainfrom
brennanb2025/tooltip-provider-consolidation
Jul 13, 2026
Merged

brennanb2025 merged 1 commit into
mainfrom
brennanb2025/tooltip-provider-consolidation

Conversation

@brennanb2025

Copy link
Copy Markdown
Contributor

Summary

  • share one TooltipProvider across the diff layout and change-navigation controls
  • preserve each tooltip trigger, content, 300 ms delay, disabled state, and accessible label
  • add a focused render regression test for the provider scope and navigation labels

Verification

  • pnpm exec oxfmt --check src/renderer/src/components/editor/EditorPanelHeader.tsx src/renderer/src/components/editor/EditorPanelHeader.test.tsx
  • pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/editor/EditorPanelHeader.test.tsx src/renderer/src/components/editor/diff-navigation-context.test.tsx
  • pnpm exec tsc --noEmit -p config/tsconfig.tc.web.json
  • pnpm exec oxlint src/renderer/src/components/editor/EditorPanelHeader.tsx src/renderer/src/components/editor/EditorPanelHeader.test.tsx
  • pnpm exec oxlint --config config/oxlint-react-doctor.json src/renderer/src/components/editor/EditorPanelHeader.tsx src/renderer/src/components/editor/EditorPanelHeader.test.tsx
  • git diff --check

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bedf69fe-828c-48fb-a7cf-f5771ebe5b2c

📥 Commits

Reviewing files that changed from the base of the PR and between 2306f82 and f31b283.

📒 Files selected for processing (2)
  • src/renderer/src/components/editor/EditorPanelHeader.test.tsx
  • src/renderer/src/components/editor/EditorPanelHeader.tsx

📝 Walkthrough

Walkthrough

EditorPanelHeader now renders adjacent diff controls within a single shared TooltipProvider and retains the configured tooltip timing. A Vitest test adds mocked dependencies and an active-file fixture, then verifies the provider count, tooltip count, delay duration, and previous/next change accessibility labels in the rendered markup.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers summary and verification, but it omits required Screenshots, Testing checklist, AI Review Report, Security Audit, and Notes sections. Add the missing template sections, including screenshots/no visual change, checklist items, AI review report with cross-platform checks, security audit, and notes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: consolidating diff header tooltip providers.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brennanb2025

Copy link
Copy Markdown
Contributor Author

Confirmed the grouped-tooltip timing change is intentional. Sharing the Radix TooltipProvider means the first tooltip still honors the 300 ms delay, while moving directly between these adjacent diff controls can use Radix's normal skip-delay behavior. These controls form one compact toolbar group, so faster tooltip scanning after initial discovery is the desired UX rather than a regression.

@brennanb2025
brennanb2025 merged commit 550c41a into main Jul 13, 2026
3 checks passed
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant