Repository navigation
Conversation
|
Important Review skippedWe couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdds an optional terminal font fallback stack with trimming, case-insensitive deduplication, invalid-value filtering, and a maximum of 32 entries. Ghostty mappings, IPC updates, and persisted settings now normalize fallback values. Terminal font-family construction and xterm updates include configured fallbacks. Settings UI controls support adding, editing, reordering, removing, and searching fallback fonts, with new localization strings and tests. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
src/renderer/src/components/settings/TerminalFontFallbackSetting.tsx (1)
69-72: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse hash-based locale keys instead of named keys.
All
translatecalls in this file use named keys (e.g.,TerminalFontFallbackSetting.list,.moveUp,.entryLabel) while the existing codebase convention — includingSettingsFormControls.tsxin the same directory — uses 10-character hash-based keys (e.g.,a4ff6143f8). The same pattern appears inTerminalAppearanceSection.tsx(line 241, 258) andterminal-typography-search.ts(lines 38, 42, 53). Based on learnings, settings components should usetranslate('auto.components.<Dir>.<ComponentFile>.<10-char-hash>', 'Default English text')and runpnpm bootstrap:locale-catalogto propagate translations.Source: Learnings
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: cb3a88cf-030d-4287-b329-c5fdebacfdbc
📥 Commits
Reviewing files that changed from the base of the PR and between d509ee7 and 76dd51521dc3a7b4bc030b7c4082ef23d3d14327.
📒 Files selected for processing (26)
src/main/ghostty/mapper.test.tssrc/main/ghostty/mapper.tssrc/main/ipc/settings.test.tssrc/main/ipc/settings.tssrc/main/persistence.test.tssrc/main/persistence.tssrc/renderer/src/components/settings/SettingsFormControls.tsxsrc/renderer/src/components/settings/TerminalAppearanceSection.tsxsrc/renderer/src/components/settings/TerminalFontFallbackSetting.test.tsxsrc/renderer/src/components/settings/TerminalFontFallbackSetting.tsxsrc/renderer/src/components/settings/TerminalSettingsPreview.tsxsrc/renderer/src/components/settings/terminal-typography-search.tssrc/renderer/src/components/terminal-pane/layout-serialization.test.tssrc/renderer/src/components/terminal-pane/layout-serialization.tssrc/renderer/src/components/terminal-pane/terminal-appearance.test.tssrc/renderer/src/components/terminal-pane/terminal-appearance.tssrc/renderer/src/components/terminal-pane/use-terminal-pane-lifecycle.tssrc/renderer/src/i18n/locales/en.jsonsrc/renderer/src/i18n/locales/es.jsonsrc/renderer/src/i18n/locales/ja.jsonsrc/renderer/src/i18n/locales/ko.jsonsrc/renderer/src/i18n/locales/zh.jsonsrc/shared/constants.tssrc/shared/terminal-font-fallbacks.test.tssrc/shared/terminal-font-fallbacks.tssrc/shared/types.ts
|
Rebased onto current The fallback-font setting now lives in the current persistence/settings shape:
Force-pushed |
bf2268f to
8e23086
Compare
Summary
Closes #8367.
Adds an ordered Fallback Fonts setting under Settings → Terminal → Terminal Typography so multilingual terminal glyphs resolve predictably:
Primary font → user-defined fallbacks → Orca defaultsfont-familyentries as primary + ordered fallbacks.Screenshots
Settings UI changed. Screenshots are not attached from this CLI-only run; the new control is covered by focused component tests for add, edit, focus retention, reorder, remove, duplicate rejection, and the 32-font boundary.
Testing
pnpm lint— full-repo lint not rerun; changed-file oxlint, React Doctor lint from the pre-commit hook, localization gates, max-lines ratchet, andgit diff --checkpassedpnpm typecheckpnpm test— focused suites passed: 510 tests across 9 files; the full suite was not completed under the local unsupported Node 26 runtimepnpm buildFocused coverage includes:
monospacefallback;AI Review Report
Implemented and reviewed with orchestrated AI agents, including a Claude Opus architecture review and an independent Codex diff/UX review.
The reviews explicitly checked:
[], preserving the previous effective font stack byte-for-byte when no custom fallbacks are configured.The independent review flagged and we fixed:
Menlo Extra;monospacecould suppress the required trailing CSS generic;No blocking findings remain.
Security Audit
JSON.stringifybefore entering xterm's CSSfont-familyoption, preventing malformed quote/comma construction from hand-built CSS strings.No security follow-up is needed.
Notes
monospaceis intentionally omitted from the middle of the stack so Orca retains one final unquoted generic fallback.ELI5
Under Terminal Typography you can set an ordered list of fallback fonts for characters your primary font lacks. Multilingual glyphs resolve more predictably: primary font, then your fallbacks, then Orca defaults.