Repository navigation
Conversation
Unconditional CSI-u on macOS/Linux injected literal `[13;2u` when the app had not enabled Kitty keyboard. Gate CSI-u on active KKP flags, keep Windows agent-declared CSI-u for Droid/Grok, and avoid Ctrl+Enter CSI-u without the handshake.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughWindows Shift+Enter encoding now supports CSI-u for trusted Grok process evidence. Shortcut resolution gates non-local Windows CSI-u behavior on kitty keyboard activity, falling back to alt-enter when inactive. Ctrl+Enter now returns no action when kitty is inactive and emits CSI-u when active. Tests were updated and expanded to cover these conditions across Windows encodings and shortcut forwarding paths. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #8427, now merged. That fix keeps the live Kitty-state gate for off-Windows Shift+Enter, adds Electron inactive/active/reset coverage, and preserves existing Ctrl+Enter plus Droid-only Windows routing after real Grok 0.2.93 verification showed the broader changes here could regress those paths. Thanks for identifying the core CSI-u leak. |
Summary
\x1b[13;2u) on macOS/Linux when the pane has not enabled Kitty keyboard — that path leaked as literal[13;2u(user-visible garble, especially in Grok).\x1b[13;5u).Closes #8385.
Screenshots
No visual design change. Before: Shift+Enter without KKP could paint
[13;2uinto the Grok composer. After: Esc+CR until KKP is active, then CSI-u.Testing
pnpm lintpnpm typecheckterminal-shortcut-policy.test.ts+terminal-windows-shift-enter.test.ts(42/42)pnpm buildAI Review Report
Reviewed against Grok-only, local macOS/Windows, terminal-TUI (not Native Chat). Confirmed the leaked text matches CSI-u Shift+Enter. Windows agent-declared CSI-u for Droid remains unconditional (#7620). Grok gets the same Windows declaration so trusted Grok newlines match its KKP path from #7944. Remote/SSH Windows clients still use Esc+CR when ConPTY classification is not local.
Security Audit
No new IPC, filesystem, network, auth, secrets, or dependency surface. Only changes which already-trusted key chord bytes are written to an open PTY.