Repository navigation
Close Architecture Scryer release gate - #6766
Nikolatesla-lj wants to merge 45 commits into
Conversation
…tegration # Conflicts: # package.json
…ate-clean # Conflicts: # package.json # pnpm-lock.yaml # src/main/persistence.ts # src/main/runtime/orchestration/coordinator.test.ts # src/renderer/src/components/automations/AutomationsPage.tsx # src/renderer/src/components/automations/automation-run-view-state.test.ts # src/renderer/src/components/automations/automation-usage-model.test.ts # src/renderer/src/components/tab-group/useTabGroupWorkspaceModel.ts # src/renderer/src/components/terminal-pane/pty-connection.ts # src/renderer/src/hooks/resolve-zoom-target.ts # src/renderer/src/lib/automation-session-reuse.test.ts # src/shared/automations-types.ts
|
Codex review result: Standards axis fails because this PR adds new max-lines disables, which AGENTS.md explicitly forbids. Spec axis for #28/#29/#30/#36 passes based on ArchitectureViewDto/readView/executeOperation paths and live UI/file-effect coverage. Local verification passed: tc; backend focused Vitest 19 files/91 tests; renderer/session Vitest 11 files/198 tests; e2e build; Architecture Electron e2e 22/22. I am not merging while the Standards finding remains. |
|
Standards waiver accepted for this release PR: Codex review found newly added max-lines disables, which conflict with AGENTS.md. We are intentionally not splitting the 19 large Scryer migration files in this PR because that would introduce a broad structural refactor after the release gate already passed. Waiver scope is limited to this PR and does not change the default rule for future work. Verification remains green locally: tc; backend focused Vitest 19/91; renderer/session Vitest 11/198; e2e build; Architecture Electron e2e 22/22. |
…ate-clean # Conflicts: # src/main/runtime/orca-runtime.ts # src/renderer/src/App.tsx
|
Codex release step update: after syncing latest origin/main again, local verification passed: tc; focused Vitest 30 files/290 tests; electron-vite build --mode e2e; Architecture Electron e2e 22/22. PR is mergeable from GitHub's view, but the merge attempt failed because the current account does not have stablyai/orca MergePullRequest permission. A maintainer with merge rights needs to run the final squash merge. |
Summary
Verification
corepack pnpm run tccorepack pnpm exec vitest run --config config/vitest.config.ts src/main/ipc/architecture.test.ts src/main/ipc/architecture-view-ipc.test.ts src/main/ipc/architecture-edit-session-ipc.test.ts src/main/scryer/mcp-tools.test.tscorepack pnpm exec vitest run --config config/vitest.config.ts src/main/scryer/engine/*.test.ts src/main/scryer/engine/**/*.test.tscorepack pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/architecture/*.test.ts src/renderer/src/lib/session-write-subscriber.test.ts src/renderer/src/lib/workspace-session-patch.test.tscorepack pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/store/slices/tabs.test.ts src/renderer/src/store/slices/store-session-cascades.test.tsSKIP_BUILD=1 corepack pnpm exec playwright test tests/e2e/architecture-tab.spec.ts tests/e2e/architecture-human-checklist.spec.ts tests/e2e/architecture-session-regression.spec.ts --config tests/playwright.config.ts --project electron-headless --workers=1(22 passed)Notes
ELI5
Hardens the Architecture Scryer release gate with stricter tests and docs so Scryer can ship with clearer confidence. Mostly quality/gating work rather than a user-facing app feature.