Skip to content

refactor: extract TerminalPane hooks and modularize terminal themes - #66

Merged
AmethystLiang merged 1 commit into
mainfrom
AmethystLiang/quickRefactor
Mar 23, 2026
Merged

AmethystLiang merged 1 commit into
mainfrom
AmethystLiang/quickRefactor

Conversation

@AmethystLiang

Copy link
Copy Markdown
Contributor

Summary

  • Extracted custom hooks from TerminalPane.tsx into focused modules: use-terminal-pane-lifecycle, use-terminal-pane-context-menu, use-terminal-pane-global-effects, use-system-prefers-dark
  • Split the monolithic terminal-themes-data.ts (770+ lines) into organized modules under terminal-themes/ (defaults, popular-dark, popular-light, classic, shared, types)
  • Added pane-helpers.ts for shared utility functions

Test plan

  • Verify terminal pane renders and functions correctly
  • Verify context menu works on right-click
  • Verify terminal theme switching works
  • Verify dark/light mode detection works
  • Verify pane split/close lifecycle works

🤖 Generated with Claude Code

Split the monolithic TerminalPane component into focused custom hooks
(lifecycle, context menu, global effects, dark mode detection) and break
the large terminal-themes-data file into organized modules.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@AmethystLiang
AmethystLiang force-pushed the AmethystLiang/quickRefactor branch from 083585d to 200ea6f Compare March 23, 2026 23:31
@AmethystLiang
AmethystLiang merged commit 5765791 into main Mar 23, 2026
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
…tablyai#66)

Split the monolithic TerminalPane component into focused custom hooks
(lifecycle, context menu, global effects, dark mode detection) and break
the large terminal-themes-data file into organized modules.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant