[caioribeiroclw-pixel]

Summary

Adds OMP as a first-class skill provider in skill discovery, scanning ~/.omp/agent/skills alongside Codex, Claude, and Agent Skills homes.

This follows the confirmation in #6369 that OMP consumes skills from ~/.omp/agent/skills, so future OMP users/devices do not need a manual symlink for Orca's skill discovery UI to see those skills.

Changes

• Add omp to SkillProvider.
• Add a home discovery source: OMP home → ~/.omp/agent/skills.
• Add the OMP provider label in the skills page.
• Extend the skill discovery test to cover an OMP skill package and source root.

Screenshots

No visual behavior change beyond adding the OMP provider label for discovered OMP skills in the existing skills list UI.

Testing

• pnpm lint — not run separately; this PR only touches a typed provider union/source list, UI label map, and a focused discovery test.
• pnpm exec tsgo --noEmit -p config/tsconfig.node.json
• pnpm exec tsgo --noEmit -p config/tsconfig.tc.web.json
• pnpm vitest run --config config/vitest.config.ts src/main/skills/discovery.test.ts
• pnpm build — not run; targeted typechecks and discovery tests passed.
• Added or updated high-quality tests that would catch regressions, or explained why tests were not needed
• git diff --check

Note: this environment uses Node v22.22.2, so pnpm install --frozen-lockfile printed the repo's Node 24 engine warning. The targeted tests/typechecks above still passed.

AI Review Report

I reviewed the change for the main compatibility risks touched by this PR:

• provider enum/string consistency across shared types, main-process discovery, renderer labels, and tests;
• path handling for macOS/Linux/Windows, especially os.homedir() plus path joining rather than shell expansion;
• no changes to shortcuts, shell execution, Electron IPC, or runtime skill loading behavior;
• no accidental broadening of scans beyond the explicit OMP skill home.

The generated review bot did not produce actionable code comments. It did flag the missing PR-template sections, which this update fills in.

Security Audit

Security-sensitive review points:

• This PR does not execute skill content, install dependencies, invoke shell commands, or add network access.
• It only adds one additional local discovery directory: ~/.omp/agent/skills.
• The directory is constructed from the user's home directory and fixed path segments, not from user input.
• No credentials, auth state, secrets, or config mutation paths are touched.
• No Electron IPC boundary changes are introduced.

Follow-up: if Orca later supports configurable skill homes, that path should be validated and represented distinctly from fixed provider homes.

Notes

The provider label is intentionally OMP to match the user-facing provider name in #6369. The source label is OMP home, mirroring the existing Codex home / Claude home pattern.

ELI5

Skill discovery includes OMP’s home folder (~/.omp/agent/skills) as a first-class source. OMP skills show up in Orca without manual symlinks.

[coderabbitai]

📝 Walkthrough

Walkthrough

SkillProvider now includes omp. Skill discovery adds ~/.omp/agent/skills as home-omp with provider omp. The discovery test covers an OMP-backed Planning skill and adds the local scan-root assertion. The skills page maps omp to the OMP display label.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	Title is concise and matches the main change: adding OMP skill discovery support.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The PR description follows the required template and includes summary, screenshots, testing, AI review, security audit, and notes with cross-platform coverage confirmed.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[brennanb2025]

Thanks for this — the diagnosis in #6369 was right and the OMP home path is correct. I've pushed a few changes on top so it can land.

De-staled the branch. It was branched off v1.4.102-rc.0 and conflicting. source() has since grown a pathApi adapter and an owner argument, so I merged main and rebuilt the OMP entry on the current signature. Using pathApi.join (rather than the imported join) is load-bearing: it's what makes WSL discovery emit a posix path instead of a backslash path the in-distro scanner can't use.

Dropped the SkillProvider widening. ~/.omp/agent/skills is a provider home exactly like ~/.pi/agent/skills, so it now carries providers: ['agent-skills'] and identifies OMP through the newer source-level owner: 'omp' (AgentType already includes omp). That keeps src/shared/skills.ts and the Skills page label map at a zero diff. Worth flagging why this matters beyond churn: the provider filter dropdown in SkillsPage.tsx is hand-written rather than derived from the union, so a dedicated 'omp' provider would have compiled fine but shipped a badge with no matching filter option — OMP skills would have vanished under every non-"All" provider filter. owner: 'omp' is also what keeps OMP-only skills out of the Codex/Claude/Grok native-chat pickers, which owner: null would have leaked.

Added the half that was missing. orchestration-skill-coverage.ts had no omp entry, so OMP fell through to the default ['agents-home'] and the Settings → Orchestration "Agent coverage" chip could still only read Ready via ~/.agents/skills — i.e. the symlink you were trying to retire. Added an omp-home location and mapped omp: ['omp-home', 'agents-home'].

Tests. Extended the discovery test to cover the OMP root and pin owner, and added a Pi/OMP distinctness guard — both roots end in agent/skills, so dropping either leading anchor made one agent's install mark the other with a green suite. Verified both anchor mutations now fail.

Validated in a dev build with a real ~/.omp/agent/skills/orchestration: the Skills page lists it under source "OMP home" with the Agent Skills badge, and the coverage function marks omp covered from that root alone while pi, claude, and unmapped agents stay uncovered.

Two adjacent gaps are deliberately left alone: coverage matches the singular rootPath rather than rootPaths (already being handled in #8329), and remote OMP skill linking over SSH needs a separate relay change.

[greptile-apps]

Greptile Summary

This PR adds OMP (~/.omp/agent/skills) as a first-class skill discovery source alongside the existing Codex, Claude, Grok, Pi, Gemini, and other agent home directories. OMP skills are surfaced in the Orca UI without requiring a manual symlink.

• skill-discovery-sources.ts: adds a new 'home-omp' scan root (~/.omp/agent/skills) with owner: 'omp' and providers: ['agent-skills'], matching the Pi/Grok/Cursor pattern exactly.
• orchestration-skill-coverage.ts: adds the 'omp-home' location definition (segment match on ['.omp', 'agent', 'skills']) and maps the omp agent to ['omp-home', 'agents-home'], so orchestration-skill install status is tracked correctly.
• Tests: discovery.test.ts exercises actual filesystem discovery for an OMP skill; orchestration-skill-coverage.test.ts adds a cross-contamination test verifying Pi and OMP do not mark each other despite sharing the agent/skills path tail.

Confidence Score: 5/5

The change is purely additive — one new scan root, one new location definition, and accompanying tests — with no modifications to existing paths, IPC boundaries, or runtime behavior.

Every added piece mirrors the immediately-preceding Pi entry in structure and naming. The cross-contamination test for Pi vs OMP on a shared path tail, plus the owner-is-omp assertion, cover the only subtle correctness concern. No existing paths, providers, or UI mappings were altered.

Files Needing Attention: No files require special attention.

Important Files Changed

Filename	Overview
src/main/skills/skill-discovery-sources.ts	Adds OMP home source with correct path, owner, and providers — consistent with all prior agent home entries.
src/renderer/src/lib/orchestration-skill-coverage.ts	Adds omp-home location definition and agent mapping; segment matching correctly disambiguates from Pi's identical path tail.
src/main/skills/discovery.test.ts	Extends filesystem-level discovery test with an OMP skill and verifies the owner assertion; coverage is well-targeted.
src/renderer/src/lib/orchestration-skill-coverage.test.ts	New Pi/OMP cross-contamination test (including Windows-style path) fully covers the shared agent/skills suffix concern.

_{Reviews (1): Last reviewed commit: "review: guard the Pi/OMP matcher anchors" | Re-trigger Greptile}