Repository navigation
Put the orca CLI on PATH at install time for headless hosts #5842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| #!/bin/bash | ||
| # Why: register the bundled `orca-ide` CLI on PATH at package-install time. | ||
| # The in-app "Install CLI" action (CliInstaller) can never run on a headless | ||
| # server, so without this symlink `orca serve` is unreachable from the shell on | ||
| # the exact hosts that need it most. deb/rpm both run this after unpacking. | ||
| # | ||
| # The shim resolves the real app by walking up from its own location, so a | ||
| # symlink works. We discover the install dir instead of hardcoding /opt/Orca | ||
| # because electron-builder's directory name can vary by productName sanitization. | ||
| set -e | ||
|
|
||
| link="/usr/bin/orca-ide" | ||
|
|
||
| for dir in /opt/Orca /opt/orca-ide /opt/orca; do | ||
| shim="$dir/resources/bin/orca-ide" | ||
| if [ -x "$shim" ]; then | ||
| # Only manage our own symlink; never clobber an unrelated /usr/bin/orca-ide. | ||
| if [ ! -e "$link" ] || [ -L "$link" ]; then | ||
| ln -sf "$shim" "$link" | ||
| fi | ||
| break | ||
| fi | ||
| done | ||
|
|
||
| exit 0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| #!/bin/bash | ||
| # Why: remove the PATH symlink that after-install.sh created, but only if it | ||
| # still points into an Orca install dir — never delete an unrelated | ||
| # /usr/bin/orca-ide a user or other package may own. | ||
| set -e | ||
|
|
||
| link="/usr/bin/orca-ide" | ||
|
|
||
| if [ -L "$link" ]; then | ||
| target="$(readlink "$link" || true)" | ||
| case "$target" in | ||
| /opt/Orca/*|/opt/orca-ide/*|/opt/orca/*) | ||
| rm -f "$link" | ||
| ;; | ||
| esac | ||
| fi | ||
|
|
||
| exit 0 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid overwriting unrelated existing symlinks at
/usr/bin/orca-ide.Current logic force-replaces any symlink target, so an unrelated symlink at the same path gets clobbered. That contradicts the script’s own safety contract.
Suggested fix
📝 Committable suggestion