Repository navigation
fix: resolve Codex spawn failures on Windows - #562
Merged
Merged
Conversation
On Windows, resolveCodexCommand() returns .cmd files (e.g. codex.cmd from npm). Node's child_process.spawn and node-pty cannot execute batch scripts directly, causing EINVAL errors for account login and PTY timeouts for usage tracking. - Add shell: true on win32 for child_process.spawn calls (RPC fetcher, account login) - Route node-pty spawn through cmd.exe /c for .cmd/.bat files (PTY fetcher) - Patch node-pty@1.1.0 to fix winpty build on Windows: prefix batch scripts with .\ and remove Spectre-mitigated library requirement Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 14, 2026
5 tasks done
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
child_process.spawncannot execute.cmd/.batbatch scripts withoutshell: truenode-pty@1.1.0to fix Windows build: prefix batch scripts with.\in winpty.gyp and remove Spectre-mitigated library requirementAll changes are guarded by
process.platform === 'win32'checks — zero impact on macOS/Linux.Test plan
pnpm installsucceeds on Windows without Spectre-mitigated MSVC libs🤖 Generated with Claude Code
closes #589