Skip to content

Fix sidebar footer button icon sizing - #5559

Merged
nwparker merged 1 commit into
mainfrom
nwparker/taskbar-buttons
Jun 17, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/taskbar-buttons

Conversation

@nwparker

@nwparker nwparker commented Jun 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The reveal-active-workspace and workspace-board buttons in the sidebar footer looked larger than the settings and help icons beside them.

Test plan

  • Verified icon classes match SidebarSettingsHelpMenu (size-3.5 on icon-xs buttons)
  • Visual check of sidebar footer button sizing in the running app

Open in Stage

The reveal-active-workspace crosshair regressed to size-4 in #5071 while
settings, help, and workspace-board icons stayed at size-3.5. Match the
smaller icon size and tighten the right-side button gap to mirror the
settings/help cluster.
@ghost

ghost commented Jun 17, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 1 individual chapter for you:

Title
1 Adjust sidebar footer icon sizing and spacing
Open in Stage

Chapters generated by Stage for commit c4e1a68 on Jun 17, 2026 2:25am UTC.

@nwparker

Copy link
Copy Markdown
Contributor Author

Visual check

Before: reveal crosshair had regressed to size-4, making it look larger than the settings/help icons.

before

After: reveal crosshair restored to size-3.5 and the right-side button cluster uses gap-1 to match settings/help.

after

@nwparker
nwparker merged commit e14a192 into main Jun 17, 2026
2 checks passed
@nwparker
nwparker deleted the nwparker/taskbar-buttons branch June 17, 2026 02:28
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 558b8fbe-ee6b-416b-8ac7-a7ddff0ed1f5

📥 Commits

Reviewing files that changed from the base of the PR and between 1041ead and c4e1a68.

📒 Files selected for processing (2)
  • src/renderer/src/components/sidebar/ScrollToCurrentWorkspaceToolbarButton.tsx
  • src/renderer/src/components/sidebar/SidebarToolbar.tsx

📝 Walkthrough

Walkthrough

Two minor CSS utility class changes in the sidebar toolbar: the Crosshair icon in ScrollToCurrentWorkspaceToolbarButton has its size class reduced from size-4 to size-3.5, and the flex container in SidebarToolbar that holds the toolbar buttons has its horizontal gap reduced from gap-2 to gap-1. No logic, behavior, or component contracts were modified.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant