Repository navigation
Revert "fix: terminal shortcuts firing in wrong worktree" - #546
Merged
Merged
Conversation
This reverts commit 0a6ab88.
2 tasks
brennanb2025
added a commit
that referenced
this pull request
Apr 12, 2026
Reapplies the fixes from #542 which were reverted in #546 as part of the #520 revert chain. - Replace single-value initialTabCreationGuardRef with a Set so closing the last tab no longer auto-spawns a replacement terminal - Upgrade all stopPropagation to stopImmediatePropagation as defense-in-depth against duplicate window-level keydown handlers The focusedGroupId change from #542 is omitted because it targeted TabGroupSplitLayout from #520, which remains reverted. The current code already gates isActive on isVisible, providing the same protection.
4 tasks done
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #542 as part of reverting 520