[brennanb2025]

Summary

• move the git-vs-folder signal from onboarding_completed to repo_added where project selection now happens
• thread repo_added.is_git_repo through local, remote/SSH, create, nested import, and clone add paths without adding extra git I/O
• update telemetry schemas/tests and document the PostHog dashboard follow-up

Why

After project selection moved out of onboarding, onboarding_completed.is_git_repo became an always-false proxy. repo_added now records the real git-vs-folder signal at the add point.

Validation

• pnpm vitest run --config config/vitest.config.ts src/main/telemetry/validator.test.ts
• pnpm run typecheck:node

Made with Orca 🐋

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2f04d6d4-351f-4407-8dae-91381b6eb4c7

📥 Commits

Reviewing files that changed from the base of the PR and between d171f71 and dfbae5a.

📒 Files selected for processing (3)

• docs/reference/telemetry-availability.md
• src/main/telemetry/validator.test.ts
• src/renderer/src/components/onboarding/use-onboarding-flow-persistence.ts

✅ Files skipped from review due to trivial changes (1)

• docs/reference/telemetry-availability.md

🚧 Files skipped from review as they are similar to previous changes (2)

• src/main/telemetry/validator.test.ts
• src/renderer/src/components/onboarding/use-onboarding-flow-persistence.ts

---

📝 Walkthrough

Walkthrough

This pull request moves the git-vs-folder telemetry signal from onboarding_completed to repo_added events to fix a regression introduced when project selection moved out of the onboarding flow. The emitRepoAdded function signature accepts an optional isGitRepo parameter and conditionally includes the is_git_repo field in the telemetry payload. Schemas were updated to allow the new field on repo_added and remove it from onboarding_completed. The change propagates through all repository operation handlers (add, create, clone, addRemote, and nested imports), threading the correct git-vs-folder signal at each call site. Validation tests confirm the schema contract, and documentation records the scope boundary and migration strategy.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers the summary, why section, and validation steps, but is missing required sections: Screenshots, Testing checklist, AI Review Report, Security Audit, and Notes.	Add the missing required sections from the template: explicitly mark Screenshots as 'No visual change', complete the Testing checklist, include AI Review Report with cross-platform checks, provide Security Audit summary, and add Notes section.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: moving git-vs-folder signal telemetry from onboarding_completed to repo_added event.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 69fb3edd-cfa2-4986-85e7-4ef65c53cd6e

📥 Commits

Reviewing files that changed from the base of the PR and between 31f0f25 and d171f71.

📒 Files selected for processing (5)

• docs/reference/repo-added-is-git-repo-telemetry-fix.md
• src/main/ipc/repos.ts
• src/main/telemetry/validator.test.ts
• src/renderer/src/components/onboarding/use-onboarding-flow-persistence.ts
• src/shared/telemetry-events.ts

[coderabbitai]

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

onboarding_completed test payloads are missing required cohort, so these assertions are invalid.

Both tests omit cohort, but onboardingCompletedSchema requires it.

• Line 158-168 can pass for the wrong reason (missing cohort, not retired is_git_repo).
• Line 170-176 should fail despite expecting success.

Use a valid baseline payload (include cohort) in both tests, then vary only is_git_repo presence to test the intended contract.

Proposed fix

   it('rejects the retired is_git_repo field on onboarding_completed', () => {
@@
     const result = validate('onboarding_completed', {
       path: 'add_project_modal',
+      cohort: 'fresh_install',
       is_git_repo: false,
       total_duration_ms: 100
     } as never)
@@
   it('accepts onboarding_completed without is_git_repo', () => {
     const result = validate('onboarding_completed', {
       path: 'add_project_modal',
+      cohort: 'fresh_install',
       total_duration_ms: 100
     })

Also applies to: 170-176