[colinchambachan]

Summary

Refresh the worktree quick jump palette so it feels more like a dedicated switcher than a stock command list.

This PR:

• refreshes the palette chrome, spacing, row hierarchy, footer hints, and repo/current chip treatment
• adds sidebar-style live worktree status indicators to each result row
• extracts shared worktree status and palette search/result-shaping helpers so the palette and sidebar use the same activity rules
• keeps palette selection stable by worktreeId while live recent ordering changes
• fixes sidebar quick-swap shortcut handling so modal overlays do not show or react to the Cmd/Ctrl+1-9 hint state incorrectly
• adds accessibility fixes for both the palette rows and the keyboard-focusable sidebar worktree list

Screenshots

Screen.Recording.2026-04-11.at.3.19.50.PM.mov

Testing

• pnpm lint
• pnpm typecheck
• pnpm test
• pnpm build
• Added or updated high-quality tests that would catch regressions, or explained why tests were not needed

Additional verification run locally:

• pnpm exec vitest run src/renderer/src/lib/worktree-status.test.ts src/renderer/src/lib/worktree-palette-search.test.ts src/renderer/src/lib/worktree-activation.test.ts src/renderer/src/components/sidebar/WorktreeCard.test.ts --config config/vitest.config.ts
• pnpm run typecheck:web

AI Review Report

Ran an AI review/fix loop over the changed renderer files. The review explicitly checked cross-platform compatibility for macOS, Linux, and Windows, including shortcut handling, shortcut labels, path behavior, and Electron overlay interactions touched by this PR.

Main findings from review:

• the palette session reset depended on onOpenChange(true) even though the dialog is opened from external store state
• the refreshed palette rows overrode their accessible name with an incomplete aria-label
• the new sidebar keyboard handler was too global and could steal editor/input shortcuts or switch worktrees behind open modals
• the tabbable sidebar worktree list container needed explicit accessibility semantics

Changes made in response:

• moved palette-open initialization to a visible-driven effect
• removed the incomplete palette aria-label override so row content drives the accessible name again
• guarded sidebar worktree shortcuts for modal-open and editable-target cases
• added listbox semantics and active-descendant wiring to the focusable sidebar worktree list container

Security Audit

Reviewed the touched code for basic renderer-side security risks.

Checked areas:

• input handling for palette search and keyboard shortcut events
• path handling and worktree/repo identity plumbing in the extracted helper modules
• command execution and IPC surface changes in the touched files
• accidental cross-overlay behavior that could trigger actions on the wrong worktree
• dependency usage in the shared cmdk wrapper changes

Summary:

• no new command execution, auth, secrets, or IPC exposure risks were introduced by this PR
• no new path-joining or filesystem mutation logic was added in the touched code
• the main practical safety issue found was shortcut scope: worktree navigation shortcuts could fire in the wrong context; that was fixed before opening this PR
• no additional security follow-up is currently required for the changed files

Notes

• Cross-platform shortcut behavior remains runtime-gated: modifier-key logic continues to distinguish macOS vs Linux/Windows.

[AmethystLiang]

Excellent work! The extraction of the search/status logic into shared testable libraries is very clean, and the UI/accessibility improvements are top-notch. Love the attention to detail with the shortcut guards and focus management. Approved.