Repository navigation
Fix shutdown clearing active worktree/tab from wrong layer - #44
Merged
Merged
Conversation
Move activeWorktreeId/activeTabId clearing out of shutdownWorktreeTerminals (a terminal-focused store action) and into the UI component that triggers shutdown. The delete flow already handles this independently in worktrees.ts. Also fix pre-existing lint issues and extract terminal helpers to separate file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Jinwoo-H
added a commit
that referenced
this pull request
Sep 5, 2026
Jinwoo-H
added a commit
that referenced
this pull request
Sep 5, 2026
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
…blyai#44) Move activeWorktreeId/activeTabId clearing out of shutdownWorktreeTerminals (a terminal-focused store action) and into the UI component that triggers shutdown. The delete flow already handles this independently in worktrees.ts. Also fix pre-existing lint issues and extract terminal helpers to separate file. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
7 of 9 tasks
nwparker
added a commit
that referenced
this pull request
Oct 19, 2026
…l-create callers off the deprecated owner resolver Agent launch, AI-vault resume and reveal, note target and send, wake and creation seeds, native chat owner, the shell menu and active-workspace terminal creation (#22, #31-#42, #44) read the owner through runtimeEnvironmentIdWithLegacyFallbackUnlessTwin. Paste uploads images to the server its PTY id names before falling back to the workspace owner. The folder and floating branch of the terminal spawn route (#53) reads resolveOwnerWithLegacyFallback: spawn refuses a folder twin instead of following the focused server, and teardown keeps tearing raw ids down locally. Deprecated importers 31 -> 16.
nwparker
added a commit
that referenced
this pull request
Oct 19, 2026
…f the deprecated owner resolver; spawn refuses folder twins (#30497) * refactor(renderer): fold launch, resume, note-send, paste and terminal-create callers off the deprecated owner resolver Agent launch, AI-vault resume and reveal, note target and send, wake and creation seeds, native chat owner, the shell menu and active-workspace terminal creation (#22, #31-#42, #44) read the owner through runtimeEnvironmentIdWithLegacyFallbackUnlessTwin. Paste uploads images to the server its PTY id names before falling back to the workspace owner. The folder and floating branch of the terminal spawn route (#53) reads resolveOwnerWithLegacyFallback: spawn refuses a folder twin instead of following the focused server, and teardown keeps tearing raw ids down locally. Deprecated importers 31 -> 16. * test: give the paste-listener and tab-bar probes the fields the folded callers read * test: note why the folder-twin route fixture is cast * test: type the paste-owner twin fixture
This was referenced Oct 26, 2026
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
activeWorktreeId/activeTabIdclearing out ofshutdownWorktreeTerminals(a terminal-focused store action) into the UI component (WorktreeContextMenu) that triggers shutdownworktrees.ts, so the store action was doing double duty incorrectlytabIdsvariable fromshutdownWorktreeTerminalsterminal-helpers.tsto stay under max-lines limitTest plan
🤖 Generated with Claude Code