Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local worktree listing checks each pending or failed removal against every Git row, repeatedly normalizing the same paths on the main thread. With 1,000 Git rows and 100 absent pending removals, the installed implementation reads Git-row paths 101,000 times. Indexing membership once reduces that to 1,000; listings without removal records now skip row processing entirely.
The matcher preserves the existing pairwise comparator's POSIX/Windows separation, macOS
/private/tmpalias, WSL distribution case folding and case-sensitive ext4 tails, including mixed relative/Windows syntax. Failure decoration, checkout/replacement detection, leftover ordering and failure persistence retain their existing behavior. The index lives for one listing, so it needs no cross-refresh invalidation. Remote-host routing and folder-workspace behavior are unchanged.Evidence: a quiet profile of installed hourly
6d3d8245b2f84d49decc482fea9eabced4fdabcfreached path comparison through this join. The current process had five failed removal records. The N×M join predates this hourly (introduced inb5869eeaae7, #23952); this is not an hourly-regression claim. No input stall was captured concurrently, and the deterministic counts do not establish milliseconds saved or explain all observed CPU.Validation:
darwin,linux,win32arguments, including WSL UNC aliases and case-sensitive tails. Native Linux/Windows execution remains unverified.--maxWorkers=2). Includes real-Git macOS failure/recovery coverage.pnpm tc:nodepassed.pnpm check:changed --timeout=2: all 22 non-test checks passed, including node/web/CLI typechecks, formatting, lint, import boundaries and ratchets. The broad related-unit-test selection timed out after 120 seconds; this is incomplete broad-test coverage, not a passing gate. Scoped tests above completed successfully.