Skip to content

Show linked workspaces for GitHub issues - #3820

Merged
AmethystLiang merged 2 commits into
mainfrom
linked-workspace-not-showing
May 30, 2026
Merged

AmethystLiang merged 2 commits into
mainfrom
linked-workspace-not-showing

Conversation

@AmethystLiang

@AmethystLiang AmethystLiang commented May 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Replace the PR-only linked-workspace matcher with a GitHub work-item matcher that handles linkedPR and linkedIssue by repo and ignores archived workspaces.
  • Update GitHub issue rows and issue detail surfaces to make an attached workspace the primary Open workspace action while keeping Start new workspace available.
  • Preserve PR behavior by migrating existing PR paths to the unified helper.

Design And Review

  • Wrote a scratch design doc first; it is intentionally not included in the product diff.
  • Design review via auto-design-review-fix: clean after iteration 2, no P0/P1 issues remaining.
  • Implementation followed the reviewed design with no deviations.
  • Read-only completeness verification: complete, no omissions against the design.
  • Code review loop: one round with two independent reviewers; both returned clean. Reviewers also reran focused tests, typecheck:web, and git diff --check; one reviewer additionally ran pnpm run lint.

Brennan Validation

brennan-test-changes verdict: land.

  • Launched Electron from this exact worktree on CDP port 9334 and verified identity: devRepoRoot was /Users/jinjingliang/Documents/projects/orca/linked-workspace-not-showing, devBranch was linked-workspace-not-showing.
  • Used demo-project in a temp Orca profile, with read-only stablyai/demo-project issue #17 and PR #18; no real Orca issue or PR was mutated.
  • Verified issue row showed the linked workspace label, Open workspace attached to issue, and overflow Start new workspace.
  • Clicked issue row Start new workspace; Create Worktree modal opened prefilled from the issue.
  • Verified issue detail page header and sidebar showed Open workspace, attached workspace label, and detail overflow Start new workspace.
  • Clicked issue Open workspace; it activated the existing demo-project issue workspace.
  • Verified PR tab still showed linked PR workspace state and clicking PR Open workspace activated the existing PR workspace.
  • Cleanup: stopped only the Electron process tree started for validation, verified port 9334 was free, removed the temp profile, and removed the temporary smoke marker from demo-project.

Accepted validation note: early fake-repo setup produced access-denied console/app-log noise; the final registered demo-project pass succeeded and the agent classified those as harness artifacts.

Tests

  • pnpm run typecheck
  • pnpm run lint
  • pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/lib/github-work-item-workspace-attachment.test.ts (9 tests)
  • git diff --check
  • Electron smoke test for issue row, issue detail page, and PR linked-workspace behavior
  • SSH live pass not run; this is renderer metadata/activation UI only and does not change SSH/remoting behavior

Risk: medium

Historic risk metadata backfill based on the existing risk:medium label.

@nwparker nwparker added the risk:medium Medium risk change label May 30, 2026
@AmethystLiang
AmethystLiang merged commit 69a9c51 into main May 30, 2026
1 check passed
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
* fix: show linked workspaces for github issues

* fix ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:medium Medium risk change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants