Skip to content

Keep merged linked PRs purple in workspace cards - #37730

Merged
brennanb2025 merged 3 commits into
mainfrom
brennanb2025/flatback-2
Nov 3, 2026
Merged

brennanb2025 merged 3 commits into
mainfrom
brennanb2025/flatback-2

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Workspaces with multiple merged PRs could show a green open-PR icon beside purple merged icons. The collection indicator used CI results as its PR state, so passing checks also made closed and draft collections look open. This regression was introduced by #26398.

The leading collection icon now uses the linked PRs’ overall state: all merged is purple, all draft uses the draft icon, open work remains open, and a terminal collection containing a closed PR uses the closed icon. Missing PR details stay neutral. Check results remain available in the existing hover indicators and accessible summary, which now also announces PR state. Retained stale details are identified as last known.

Intended: the leading icon summarizes the collection; the linked stack’s front icon continues to represent its prioritized individual PR. A collection’s icon color now represents PR state, while its individual check indicators retain CI results. Single-PR behavior stays the same.

Plan: derive lifecycle from the existing identity-matched details in the current summary pass, independently of check availability, and reuse the existing state icons. No saved fields, wire changes, provider requests, or new UI surfaces. Full review path because this component has prior reverts.

Tracked in STA-13594.

Validation: the merged-collection regression failed on the original code for both successful and failed checks. All 50 targeted tests pass after the fix, covering mixed providers and states, unknown data, missing checks, stale details, existing activity precedence, GitLab draft terminology and a Korean announcement. All 27 changed-code checks passed after syncing current main, including all selected typechecks and related unit tests. Independent correctness and architecture reviews and the final merged-head check are complete; their shared wording finding was fixed and verified. CI passed on the final commit, including both packaging jobs, typechecks, all twelve test shards and relay integration. Renderer tests cover this icon/color and screen-reader text change; no layout or interaction changed, so no app run or screenshot was required.

@brennanb2025
brennanb2025 marked this pull request as ready for review November 3, 2026 08:14
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The shared checks summary now derives and exposes a hosted review state. It also counts stale matched reviews when status is missing. Sidebar displays use the review state alongside check status, and stale collection checks can trigger the last-known-status label and shimmer.

Merge Risk: Minimal · up to b29a5

The collection icon reflects review lifecycle while individual check results remain available. No merge-blocking issue was identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the primary change: preserving purple styling for merged linked PRs in workspace cards.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description is mostly complete. It explains the user-facing problem and solution, links the tracked issue, documents testing and CI results, describes visual impact, and identifies compatibility s…
Full details: Description check

Explanation

The description is mostly complete. It explains the user-facing problem and solution, links the tracked issue, documents testing and CI results, describes visual impact, and identifies compatibility scope. It does not use the template headings or explicitly provide a risk level, rollback plan, AI disclosure, or checklist confirmations.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 5 functions across 6 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6801c72e-5c0a-4d78-a683-75633918d072
Commits

Reviewing files that changed from the base of the PR and between 17f21e6 and b29a5ff.

Files selected for processing: 6
  • src/renderer/src/components/sidebar/WorkspaceReviewChecksIndicator.tsx
  • src/renderer/src/components/sidebar/WorktreeCardStatusSlot.test.tsx
  • src/renderer/src/components/sidebar/WorktreeCardStatusSlot.tsx
  • src/renderer/src/components/sidebar/worktree-review-helpers.tsx
  • src/shared/workspace-review-checks.test.ts
  • src/shared/workspace-review-checks.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@brennanb2025

Copy link
Copy Markdown
Contributor Author

Workspaces with several merged PRs could show a green open-PR icon next to purple merged icons because the collection indicator used check results to choose its icon.

The collection now derives its icon from the linked PRs’ lifecycle. Merged collections stay purple even when checks fail; draft and closed collections retain their corresponding icons. Checks remain available separately, and stale details are announced as last known.

Independent correctness and architecture reviews are complete. Their draft-MR wording finding was fixed and independently verified; no findings remain open or deferred.

Verification: the two merged-collection regressions failed before the fix. All 50 targeted tests and all 27 final changed-code checks pass, including renderer output, translated announcements and typechecks. CI passed on the final commit, including packaging, all twelve test shards and relay integration. The final merged-head review found no new issues.

For Brennan’s review: this changes fixed-size icons, color and screen-reader text. Renderer tests cover these outputs; no layout or interaction changed, so the review’s tests row requires no app run or screenshot.

@brennanb2025
brennanb2025 merged commit b49a019 into main Nov 3, 2026
76 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant