Repository navigation
Keep merged linked PRs purple in workspace cards - #37730
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Workspaces with several merged PRs could show a green open-PR icon next to purple merged icons because the collection indicator used check results to choose its icon. The collection now derives its icon from the linked PRs’ lifecycle. Merged collections stay purple even when checks fail; draft and closed collections retain their corresponding icons. Checks remain available separately, and stale details are announced as last known. Independent correctness and architecture reviews are complete. Their draft-MR wording finding was fixed and independently verified; no findings remain open or deferred. Verification: the two merged-collection regressions failed before the fix. All 50 targeted tests and all 27 final changed-code checks pass, including renderer output, translated announcements and typechecks. CI passed on the final commit, including packaging, all twelve test shards and relay integration. The final merged-head review found no new issues. For Brennan’s review: this changes fixed-size icons, color and screen-reader text. Renderer tests cover these outputs; no layout or interaction changed, so the review’s tests row requires no app run or screenshot. |
Workspaces with multiple merged PRs could show a green open-PR icon beside purple merged icons. The collection indicator used CI results as its PR state, so passing checks also made closed and draft collections look open. This regression was introduced by #26398.
The leading collection icon now uses the linked PRs’ overall state: all merged is purple, all draft uses the draft icon, open work remains open, and a terminal collection containing a closed PR uses the closed icon. Missing PR details stay neutral. Check results remain available in the existing hover indicators and accessible summary, which now also announces PR state. Retained stale details are identified as last known.
Intended: the leading icon summarizes the collection; the linked stack’s front icon continues to represent its prioritized individual PR. A collection’s icon color now represents PR state, while its individual check indicators retain CI results. Single-PR behavior stays the same.
Plan: derive lifecycle from the existing identity-matched details in the current summary pass, independently of check availability, and reuse the existing state icons. No saved fields, wire changes, provider requests, or new UI surfaces. Full review path because this component has prior reverts.
Tracked in STA-13594.
Validation: the merged-collection regression failed on the original code for both successful and failed checks. All 50 targeted tests pass after the fix, covering mixed providers and states, unknown data, missing checks, stale details, existing activity precedence, GitLab draft terminology and a Korean announcement. All 27 changed-code checks passed after syncing current main, including all selected typechecks and related unit tests. Independent correctness and architecture reviews and the final merged-head check are complete; their shared wording finding was fixed and verified. CI passed on the final commit, including both packaging jobs, typechecks, all twelve test shards and relay integration. Renderer tests cover this icon/color and screen-reader text change; no layout or interaction changed, so no app run or screenshot was required.