[brennanb2025]

	Files	Added	Deleted	Net
Test	1	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​2	$\color{#cf222e}{\Huge{\mathbf{−}}}$​2	0
Prod	0	0	0	0

Problem. An end-to-end test for the floating terminal panel still expected a single tab to stretch wider than 384px. #37131 deliberately changed tabs so a lone tab stops at a preferred width of 330px instead of stretching across the whole header. That test was skipped on #37131, so the outdated expectation merged unnoticed. Any later PR whose changed files make CI run this test now fails it (for example #37220), even though nothing is wrong with the app.

What this PR does. It updates the test to expect the 330px preferred width and renames it to describe today's behavior: tabs keep their preferred width when there is room, share the space equally when it gets tight, shrink down to the 144px minimum, and scroll once they no longer fit. All the checks for sharing, shrinking and restoring after a resize, and 144px overflow stay exactly as they were. Users see no change; only the test changes.

Verified. CI ran this test on this PR and it passed, including the later checks that had never been reached since #37131. Tracked in STA-13449.

Plan: test-only repair of the merged width contract; no reference mechanism applies. Full review path because the test file has width-related revert history. No production lines, saved fields or wire changes. One independent PR.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 739874d2-3df5-4585-85de-94e2380ca2ed

Commits

Reviewing files that changed from the base of the PR and between 2541edc and 0bdcf38.

Files selected for processing: 1

• tests/e2e/floating-workspace-pane-height.spec.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[brennanb2025]

Review loop status: done

The problem. An end-to-end test for the floating terminal panel still expected a lone tab to stretch wider than 384px. #37131 deliberately caps a tab's preferred width at 330px, and the test was skipped on that PR, so the outdated expectation merged. Any later PR that makes CI run this test (for example #37220) fails it, though the app itself is fine.

The change. The test now expects the 330px preferred width and has a name that describes today's behavior. Every other check in it stays: two tabs share the space equally and are narrower than one tab alone, they shrink when the panel narrows and return when it widens, three tabs share without scrolling, and twelve tabs sit at the 144px minimum and scroll. No app code changes, so users see nothing different.

What was verified.

• Three independent reviewers (correctness, user-visible result and test consumers, architecture) found no problems. Every assertion in the test was checked against the actual sizing code, and no other test still expects the old stretching behavior.
• CI ran the changed test and it passed, both on the reviewed commit (run 41417482561) and after syncing with main (run 41418927098). The checks after the first one had never run since fix(tabs): cap tab widths with intrinsic CSS sizing #37131; they all pass now.
• Synced with main once (merge 0bdcf38); main's new commits don't touch these files, and the PR still changes only those two test lines.
• No app run was needed: only a test changed.

Deferred.

• The test caps the panel width but doesn't fix the window size, so a much smaller CI window could squeeze a lone tab below 330px. That limit already existed and CI has room today.

For Brennan's review.

• Out of scope, worth a look: CI's test picker doesn't run this test when only the shared tab sizing files change (pr-feature-area-e2e-source-routes.mjs:52 matches only the floating-terminal folder). That is how fix(tabs): cap tab widths with intrinsic CSS sizing #37131 merged with the test skipped, and the same gap can let this happen again. Not fixed here.
• The changed assertion: floating-workspace-pane-height.spec.ts:194.

[brennanb2025]

Closing as superseded by merged #37456. Current main already checks the 330px preferred width and names the test for that behavior, covering both changes in this PR.