Repository navigation
test(e2e): update two WSL specs to the stopped-distro copy and serve-only Settings - #37394
Merged
Merged
Conversation
…only Settings wsl-host-paired-phone asserted the pre-#36771 'isn't running' copy; it now asserts the stable remote_runtime_unavailable code and '<distro> is stopped'. wsl-move-dialog's gate-closed case seeds a saved host, which since #34683 puts the app in serve-only: the WSL hosts section still lists the host. Assert instead that Add is hidden and the host row's menu has no move entry. Co-Authored-By: Claude <noreply@anthropic.com>
nwparker
marked this pull request as ready for review
November 2, 2026 07:38
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Two end-to-end tests for WSL hosts started failing on
main. The app is working as intended. The tests were checking for behavior that later, deliberate changes replaced, so this PR updates them to match. No product code changes.What Changed
tests/e2e/wsl-host-paired-phone.spec.ts: when a phone asks a stopped WSL host for something, the test expected the old wording "isn't running". fix(wsl): a stopped distro's messages say Start or a new terminal starts it, not switching projects #36771 changed the wording to "The WSL host Ubuntu is stopped. To start it, click Start or open a new terminal…". The test now checks the stable error coderemote_runtime_unavailableplus "Ubuntu is stopped" (the same fragment the other WSL specs check), not the full sentence.tests/e2e/wsl-move-dialog.spec.ts, case "with the internal gate closed…": this test always starts with a saved WSL host. The test landed in Land the WSL project mover dark (merges only after verify-15b, the flag-off audit and green CI) #34059. Eighteen minutes later, feat(wsl): serve saved WSL work behind a closed hosts gate (gate states, kill switch 1/2) #34683 added "serve-only" mode: with the gate closed, a saved host stays listed and usable, but you can't add hosts or move projects. Settings → Servers therefore still shows the WSL hosts section, and the test's "section is absent" check fails. The test now checks what serve-only promises: the host is listed, there's no "Add WSL distro" button, and the host row's menu shows "Remove…" but not "Move projects from this distro…". It still checks that main refuses a move preview and lists no unfinished moves.tests/e2e/helpers/paired-mobile-client.ts: adds an optionalmessagefield to the phone frame's error type so the spec can read the message.Why
Neither failure is a product regression. The new copy is the intended text (#36771), and showing a saved host's row while the gate is closed is the intended serve-only behavior (#34683, #34694). The old move-entry check looked for text that only appears in a closed dropdown menu, so it would have passed even if the entry existed. The new check opens the menu first, so the "no move entry" assertion now actually tests something. Checking the error code plus the distro fragment means future copy edits won't break the test again.
Linked Issue
N/A (maintainer; follow-up to failing CI run https://github.com/stablyai/orca/actions/runs/41405938364)
Visual Proof
N/A: test-only change, no UI or behavior change.
Testing
Both specs pass locally on macOS (headless,
ORCA_BACKGROUND_LAUNCH=1, 3/3). A targeted CI e2e dispatch was also run. Ranpnpm typecheck:e2e(no errors intests/; the e2e typecheck ratchet passes), oxlint,check:code-quality:changedandlint:ast-grep-gates.Risk
Low. Only tests change. Revert is a plain revert.
Level: Low
AI Disclosure
Review
Agent skill upstream boundary
Notes
Ensure no issues in: Security, Cross-platform support (Linux, Windows, Mac), Remote SSH, Mobile, general backwards compatibility, performance
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)🤖 Generated with Claude Code